Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-141599: Fixes Card Title Accessibility Level #2589

Merged
merged 21 commits into from
Jul 22, 2024
Merged

MWPW-141599: Fixes Card Title Accessibility Level #2589

merged 21 commits into from
Jul 22, 2024

Conversation

cmiqueo
Copy link
Contributor

@cmiqueo cmiqueo commented Jul 18, 2024

The card title accessibility level was not being read from the configurator.
Notice it is set to 3 but it shows 6
image

This PR fixes that issue
image

Resolves: MWPW-141599

Test URLs:

@cmiqueo cmiqueo requested a review from chrischrischris as a code owner July 18, 2024 04:33
Copy link
Contributor

aem-code-sync bot commented Jul 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jul 18, 2024

Page Scores Audits Google
/tools/caas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (fc03376) to head (3f432cb).
Report is 16 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2589      +/-   ##
==========================================
- Coverage   95.85%   95.85%   -0.01%     
==========================================
  Files         176      176              
  Lines       46133    46195      +62     
==========================================
+ Hits        44221    44278      +57     
- Misses       1912     1917       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmiqueo cmiqueo added bug Something isn't working caas-configurator CaaS Configurator labels Jul 18, 2024
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jul 21, 2024

Skipped merging 2589: MWPW-141599: Fixes Card Title Accessibility Level due to failing checks

1 similar comment
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jul 22, 2024

Skipped merging 2589: MWPW-141599: Fixes Card Title Accessibility Level due to failing checks

@mokimo mokimo merged commit 58a1fdf into stage Jul 22, 2024
23 of 24 checks passed
@mokimo mokimo deleted the MWPW-141599 branch July 22, 2024 15:48
@mokimo mokimo mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working caas-configurator CaaS Configurator Ready for Stage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants