MWPW-155057: Lets authors add "starting at" to merch cards #2717

Axelcureno · 2024-08-08T20:12:50Z

Lets authors add "Starting at" to merch card content before the price.

"Starting at" content can be added using the block "property" with the same value.
Content is inserted using placeholder {{starting-at}}.

Supported merch card variants:

Segment
Product
Mini compare
Catalog

Test URLs:

Preview: https://main--cc--adobecom.hlx.page/drafts/axel/stories/mwpw-155057-starting-at?milolibs=MWPW-155057--milo--adobecom

aem-code-sync · 2024-08-08T20:12:53Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

de3eb5c ✅ (latest)
255e6f7 ✅
f44a9e0 ✅
3405d6d ✅
2f92a42 ✅
d1fffd5 ✅
09830d6 ✅
e863ddb ✅
e1cdaa6 ✅
a72d563 ✅
a5f75d2 ✅
af6bff7 ✅
32f23df ✅
e7de2e2 ✅
485dd6d ✅
9190952 ✅
b1d90cc ✅
5badaa3 ✅
f5cadc7 ✅
19b3b07 ✅
4c1e13c ✅

aem-code-sync · 2024-08-08T20:13:17Z

	Page	Scores	Audits	Google
M	/drafts/axel/stories/mwpw-155057?martech=off
D	/drafts/axel/stories/mwpw-155057?martech=off
M	/drafts/axel/stories/mwpw-155057?martech=off
D	/drafts/axel/stories/mwpw-155057?martech=off

test/blocks/merch-card/merch-card.test.js

codecov · 2024-08-08T20:26:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (cfedb3c) to head (de3eb5c).
Report is 1 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #2717      +/-   ##
==========================================
- Coverage   95.91%   95.91%   -0.01%     
==========================================
  Files         173      173              
  Lines       45816    45831      +15     
==========================================
+ Hits        43943    43957      +14     
- Misses       1873     1874       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-09T01:20:57Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

narcis-radu · 2024-08-09T10:50:09Z

Hey @Axelcureno - I'm not able to see the "starting at" text in your demo page https://mwpw-155057--milo--adobecom.hlx.page/drafts/axel/stories/mwpw-155057?martech=off

robert-bogos · 2024-08-09T13:42:15Z

@Axelcureno Should we add some unit tests for this?

Axelcureno · 2024-08-09T14:15:43Z

Hey @Axelcureno - I'm not able to see the "starting at" text in your demo page https://mwpw-155057--milo--adobecom.hlx.page/drafts/axel/stories/mwpw-155057?martech=off

@narcis-radu that's strange, I still see the change. Maybe try clearing cache?

mirafedas · 2024-08-13T12:53:46Z

@Axelcureno I guess we probably should update the authoring documentation after this change is live

overmyheadandbody

Just a nit for the description:

Content is inserted using placeholder {{starting-as}}.

has a small typo, should be {{starting-at}}, just to avoid any confusion

npeltier

nit request

npeltier · 2024-08-14T07:50:47Z

libs/blocks/merch-card/merch-card.js

+    const { replaceKey } = await import('../../features/placeholders.js');
+    await replaceKey('starting-at', getConfig()).then((key) => {
+      const startingAt = createTag('div', { slot: 'starting-at' }, key);
+      const prices = merchCard.querySelectorAll('span[is="inline-price"]');


please rather use querySelector if you are just going to use the first one

afmicka · 2024-08-14T11:42:08Z

@Axelcureno your changes are adding/exposing   within the price. Could you please take a look? cc: @Roycethan

Could you also update the branch with the stage latest and make sure you don't have stale block so that we can validate the PR? This issue has been seen in the recent Stage to Main PRs.

https://main--cc--adobecom.hlx.live/pl/creativecloud?milolibs=mwpw-155057

Axelcureno · 2024-08-14T16:22:55Z

@Axelcureno your changes are adding/exposing   within the price. Could you please take a look? cc: @Roycethan

Could you also update the branch with the stage latest and make sure you don't have stale block so that we can validate the PR? This issue has been seen in the recent Stage to Main PRs.

https://main--cc--adobecom.hlx.live/pl/creativecloud?milolibs=mwpw-155057

@afmicka It wasn't my changes that were adding the   but I have updated my branch with latest stage and the characters are now gone.

milo-pr-merge · 2024-08-19T08:12:49Z

Skipped 2717: "MWPW-155057: Lets authors add "starting at" to merch cards" due to file "libs/deps/mas/merch-card-all.js" overlap. Merging will be attempted in the next batch

milo-pr-merge · 2024-08-20T18:10:42Z

Skipped 2717: "MWPW-155057: Lets authors add "starting at" to merch cards" due to file "libs/deps/mas/merch-card-all.js" overlap. Merging will be attempted in the next batch

Axelcureno added 4 commits August 7, 2024 16:30

MWPW-155057: [Merch cards] Add ability for authors to add "starting at"

4c1e13c

Preview: https://main--cc--adobecom.hlx.page/drafts/axel/stories/mwpw-155057-starting-at?milolibs=MWPW-155057--milo--adobecom

improved impl

19b3b07

unit tests

f5cadc7

Update merch-card.js

5badaa3

Axelcureno added run-nala Run Nala Test Automation against PR commerce needs-verification PR requires E2E testing by a reviewer merch card labels Aug 8, 2024

Axelcureno requested a review from mirafedas August 8, 2024 20:12

Axelcureno self-assigned this Aug 8, 2024

Axelcureno requested review from a team as code owners August 8, 2024 20:12

github-actions bot reviewed Aug 8, 2024

View reviewed changes

test/blocks/merch-card/merch-card.test.js Outdated Show resolved Hide resolved

Update merch-card.test.js

b1d90cc

aem-code-sync bot temporarily deployed to MWPW-155057 August 8, 2024 20:18 Inactive

Update segment-card.html

9190952

aem-code-sync bot temporarily deployed to MWPW-155057 August 9, 2024 01:30 Inactive

unit test

485dd6d

aem-code-sync bot temporarily deployed to MWPW-155057 August 9, 2024 21:48 Inactive

Update merch-card.js

e7de2e2

aem-code-sync bot temporarily deployed to MWPW-155057 August 9, 2024 21:54 Inactive

Update merch-card.js

32f23df

aem-code-sync bot temporarily deployed to MWPW-155057 August 9, 2024 21:57 Inactive

aem-code-sync bot temporarily deployed to MWPW-155057 August 12, 2024 17:17 Inactive

Update merch-card.js

d1fffd5

aem-code-sync bot temporarily deployed to MWPW-155057 August 12, 2024 17:19 Inactive

mirafedas approved these changes Aug 13, 2024

View reviewed changes

overmyheadandbody approved these changes Aug 13, 2024

View reviewed changes

Axelcureno requested review from afmicka and Roycethan August 13, 2024 14:16

npeltier approved these changes Aug 14, 2024

View reviewed changes

Merge branch 'stage' into MWPW-155057

2f92a42

aem-code-sync bot temporarily deployed to MWPW-155057 August 14, 2024 16:20 Inactive

Roycethan added the verified PR has been E2E tested by a reviewer label Aug 14, 2024

Roycethan approved these changes Aug 14, 2024

View reviewed changes

unit test and pr feedback

3405d6d

aem-code-sync bot temporarily deployed to MWPW-155057 August 14, 2024 18:29 Inactive

Roycethan added Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Aug 14, 2024

Axelcureno added 2 commits August 19, 2024 07:43

Merge branch 'stage' into MWPW-155057

f44a9e0

conflicts resolved

255e6f7

aem-code-sync bot temporarily deployed to MWPW-155057 August 19, 2024 14:45 Inactive

robert-bogos approved these changes Aug 20, 2024

View reviewed changes

Merge branch 'stage' into MWPW-155057

de3eb5c

aem-code-sync bot deployed to MWPW-155057 August 20, 2024 19:26 View deployment

milo-pr-merge bot merged commit 2abe70f into stage Aug 20, 2024
12 checks passed

milo-pr-merge bot deleted the MWPW-155057 branch August 20, 2024 20:11

milo-pr-merge bot mentioned this pull request Aug 20, 2024

[Release] Stage to Main #2766

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-155057: Lets authors add "starting at" to merch cards #2717

MWPW-155057: Lets authors add "starting at" to merch cards #2717

Axelcureno commented Aug 8, 2024 •

edited

Loading

aem-code-sync bot commented Aug 8, 2024 •

edited

Loading

aem-code-sync bot commented Aug 8, 2024 •

edited

Loading

codecov bot commented Aug 8, 2024 •

edited

Loading

github-actions bot commented Aug 9, 2024

narcis-radu commented Aug 9, 2024

robert-bogos commented Aug 9, 2024

Axelcureno commented Aug 9, 2024

mirafedas commented Aug 13, 2024

overmyheadandbody left a comment

npeltier left a comment

npeltier Aug 14, 2024

afmicka commented Aug 14, 2024 •

edited

Loading

Axelcureno commented Aug 14, 2024

milo-pr-merge bot commented Aug 19, 2024

milo-pr-merge bot commented Aug 20, 2024

MWPW-155057: Lets authors add "starting at" to merch cards #2717

MWPW-155057: Lets authors add "starting at" to merch cards #2717

Conversation

Axelcureno commented Aug 8, 2024 • edited Loading

aem-code-sync bot commented Aug 8, 2024 • edited Loading

aem-code-sync bot commented Aug 8, 2024 • edited Loading

codecov bot commented Aug 8, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 9, 2024

narcis-radu commented Aug 9, 2024

robert-bogos commented Aug 9, 2024

Axelcureno commented Aug 9, 2024

mirafedas commented Aug 13, 2024

overmyheadandbody left a comment

Choose a reason for hiding this comment

npeltier left a comment

Choose a reason for hiding this comment

npeltier Aug 14, 2024

Choose a reason for hiding this comment

afmicka commented Aug 14, 2024 • edited Loading

Axelcureno commented Aug 14, 2024

milo-pr-merge bot commented Aug 19, 2024

milo-pr-merge bot commented Aug 20, 2024

Axelcureno commented Aug 8, 2024 •

edited

Loading

aem-code-sync bot commented Aug 8, 2024 •

edited

Loading

aem-code-sync bot commented Aug 8, 2024 •

edited

Loading

codecov bot commented Aug 8, 2024 •

edited

Loading

afmicka commented Aug 14, 2024 •

edited

Loading