-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-155529 - Notification design parity #2726
MWPW-155529 - Notification design parity #2726
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2726 +/- ##
==========================================
+ Coverage 95.75% 95.89% +0.14%
==========================================
Files 173 173
Lines 45733 45771 +38
==========================================
+ Hits 43791 43894 +103
+ Misses 1942 1877 -65 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing those things, looks good.
This PR is currently in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-155529
decorateBlockText
so "detail" text styles are not applied to product lockups.Resolves: MWPW-155529
Test URLs:
Test Page from ticket reporter:
Banners
Ribbons