Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-155529 - Notification design parity #2726

Merged
merged 9 commits into from
Aug 19, 2024

Conversation

elan-tbx
Copy link
Contributor

@elan-tbx elan-tbx commented Aug 12, 2024

@elan-tbx elan-tbx added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Aug 12, 2024
@elan-tbx elan-tbx requested a review from a team as a code owner August 12, 2024 16:57
Copy link
Contributor

aem-code-sync bot commented Aug 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Aug 12, 2024

@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-155529-notification-parity August 12, 2024 17:07 Inactive
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (60cb005) to head (a2920f4).
Report is 17 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2726      +/-   ##
==========================================
+ Coverage   95.75%   95.89%   +0.14%     
==========================================
  Files         173      173              
  Lines       45733    45771      +38     
==========================================
+ Hits        43791    43894     +103     
+ Misses       1942     1877      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-155529-notification-parity August 12, 2024 17:18 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-155529-notification-parity August 12, 2024 17:34 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-155529-notification-parity August 12, 2024 20:57 Inactive
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

libs/blocks/notification/notification.css Outdated Show resolved Hide resolved
libs/blocks/notification/notification.css Show resolved Hide resolved
libs/blocks/notification/notification.js Outdated Show resolved Hide resolved
libs/blocks/notification/notification.js Outdated Show resolved Hide resolved
@elan-tbx elan-tbx requested a review from ryanmparrish August 13, 2024 19:55
Copy link
Contributor

@ryanmparrish ryanmparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those things, looks good.

Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@NadiiaSokolova NadiiaSokolova self-assigned this Aug 16, 2024
Copy link

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-155529

@milo-pr-merge milo-pr-merge bot merged commit 274a603 into stage Aug 19, 2024
16 checks passed
@milo-pr-merge milo-pr-merge bot deleted the ebartholomew/MWPW-155529-notification-parity branch August 19, 2024 08:12
@milo-pr-merge milo-pr-merge bot mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires E2E testing by a reviewer Ready for Stage run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants