Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a line break before 'ー U+2013', '〜 U+301C', and etc in Japanese #2751

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

tamanyan
Copy link
Contributor

@tamanyan tamanyan commented Aug 16, 2024

Prevent a line break before 'ー U+2013', '〜 U+301C', and etc in Japanese.

Refer from https://drafts.csswg.org/css-text-3/#line-break-property

Before

After

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Aug 16, 2024

Page Scores Audits Google
M /jp/drafts/takyoshi/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /jp/drafts/takyoshi/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (f92f07c) to head (3335727).
Report is 13 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2751      +/-   ##
==========================================
- Coverage   95.88%   95.87%   -0.01%     
==========================================
  Files         173      173              
  Lines       45771    45810      +39     
==========================================
+ Hits        43886    43919      +33     
- Misses       1885     1891       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tamanyan tamanyan changed the title Prevent link breaks before 'ー U+2013', '〜 U+301C' Prevent link breaks before 'ー U+2013', '〜 U+301C' in Japanese Aug 16, 2024
@tamanyan tamanyan changed the title Prevent link breaks before 'ー U+2013', '〜 U+301C' in Japanese Prevent link breaks before 'ー U+2013', '〜 U+301C' etc in Japanese Aug 16, 2024
@tamanyan tamanyan changed the title Prevent link breaks before 'ー U+2013', '〜 U+301C' etc in Japanese Prevent link breaks before 'ー U+2013', '〜 U+301C', and etc in Japanese Aug 16, 2024
@vhargrave vhargrave self-requested a review August 16, 2024 09:12
Copy link
Contributor

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamanyan tamanyan changed the title Prevent link breaks before 'ー U+2013', '〜 U+301C', and etc in Japanese Prevent line breaks before 'ー U+2013', '〜 U+301C', and etc in Japanese Aug 16, 2024
@tamanyan tamanyan changed the title Prevent line breaks before 'ー U+2013', '〜 U+301C', and etc in Japanese Prevent a line break before 'ー U+2013', '〜 U+301C', and etc in Japanese Aug 16, 2024
libs/styles/styles.css Outdated Show resolved Hide resolved
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Aug 20, 2024

Skipped merging 2751: Prevent a line break before 'ー U+2013', '〜 U+301C', and etc in Japanese due to failing checks

@mokimo mokimo merged commit cfedb3c into adobecom:stage Aug 20, 2024
14 of 15 checks passed
@mokimo mokimo mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants