-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent a line break before 'ー U+2013', '〜 U+301C', and etc in Japanese #2751
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2751 +/- ##
==========================================
- Coverage 95.88% 95.87% -0.01%
==========================================
Files 173 173
Lines 45771 45810 +39
==========================================
+ Hits 43886 43919 +33
- Misses 1885 1891 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
I also tested it on two express pages and could see the difference
before: https://jp-text--express-milo--adobecom.hlx.page/jp/express/feature/image/remove-background
after: https://jp-text--express-milo--adobecom.hlx.page/jp/express/feature/image/remove-background?milolibs=stage--milo--tamanyan
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Skipped merging 2751: Prevent a line break before 'ー U+2013', '〜 U+301C', and etc in Japanese due to failing checks |
Prevent a line break before 'ー U+2013', '〜 U+301C', and etc in Japanese.
Refer from https://drafts.csswg.org/css-text-3/#line-break-property
Before
After
Test URLs: