Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-156872 - Add no borders variant to Accordion block #2755

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

elan-tbx
Copy link
Contributor

  • A request has been made to add a no borders option to the Accordion block. Like the variant name implies, this removes the gray separators in between accordion items.
  • Note that this has been marked as a critical update in Jira.

Resolves: MWPW-156872

Test URLs:

@elan-tbx elan-tbx added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Aug 18, 2024
Copy link
Contributor

aem-code-sync bot commented Aug 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Aug 18, 2024

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (f92f07c) to head (db36ecb).
Report is 8 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2755      +/-   ##
==========================================
+ Coverage   95.88%   95.90%   +0.01%     
==========================================
  Files         173      173              
  Lines       45771    45771              
==========================================
+ Hits        43886    43895       +9     
+ Misses       1885     1876       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elan-tbx elan-tbx assigned elan-tbx and NadiiaSokolova and unassigned elan-tbx Aug 19, 2024
Copy link

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-156872

@milo-pr-merge milo-pr-merge bot merged commit 5a1dcab into stage Aug 19, 2024
21 of 23 checks passed
@milo-pr-merge milo-pr-merge bot deleted the ebartholomew/MWPW-156872-no-borders-accordion branch August 19, 2024 16:11
@milo-pr-merge milo-pr-merge bot mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires E2E testing by a reviewer Ready for Stage run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants