MWPW-156135 - [editorial-card] bugs #2771
Conversation
…y. Fixes naming collision w background rounded corners. ;)
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2771 +/- ##
==========================================
+ Coverage 95.89% 95.91% +0.01%
==========================================
Files 173 173
Lines 45746 45844 +98
==========================================
+ Hits 43870 43971 +101
+ Misses 1876 1873 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-156135
|
Skipped 2771: "MWPW-156135 - [editorial-card] bugs" due to file "libs/styles/styles.css" overlap. Merging will be attempted in the next batch |
| /* Tablet up */ | ||
| @media screen and (min-width: 600px) { | ||
| .editorial-card .vp-media .mobile-only, | ||
| .editorial-card .vp-media .desktop-only { |
There was a problem hiding this comment.
I like the consistency, but I think this line is not really needed, desktop-only is already hidden on mobile.
.
We can keep the code for consistency purposes however.
* Fixed decBg func. was incorrectly removing bg row * allow className in decorateBG and support vp-media on card row display. Fixes naming collision w background rounded corners. ;) * remove device js set type classes and put direct in .display styles * Fix text-block bg zIndex * fh on bg vids * no await, decorate * Support 'open' and three rows authoring for flat doc examples. * 3 rows default = media, copy, foot * equal w/ 3 not 4 * Revert extra changes w/ row-order defatult for diff branch * linting and no z-index needed
Fixed the following bugs
.backgroundcausing a style naming collision. I am passing this className as a parameter now.Resolves: MWPW-156135
Test URLs:
Before: https://main--milo--adobecom.hlx.page/drafts/rparrish/cards/editorial-cards-bugz?martech=off
After: https://rparrish-editorial-bugz--milo--adobecom.hlx.page/drafts/rparrish/cards/editorial-cards-bugz?martech=off