Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-151936 - Aside Tiger Team Enhancements (a new hope) #2782

Merged
merged 13 commits into from
Aug 29, 2024

Conversation

elan-tbx
Copy link
Contributor

  • After extensive testing (including 137 pages on BACOM!), it appears there are no longer any adverse/unintentional effects on any current/future uses of this block. The latest issues so far have been centered around the notification and promobar variants of the Aside block; had the timeline of this work gone as expected, this could have been addressed in a cleaner way (updating authoring to use the new Notification block, adding a fast-follow to this work, etc.) but alas, here we are.
  • The offending bugs that caused this PR to get reverted this week are as follows:
  • This PR also addresses an edge case in the promobar aside, described in the second ticket listed below (stacking of CTAs on desktop)
  • As before, I will add @meganthecoder's extensive documentation in a comment below to preserve healthy PSI scores.

Resolves: MWPW-151936, MWPW-148459

Test URLs:

@elan-tbx elan-tbx added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer high priority Why is this a high priority? Blocker? Critical? Dependency? labels Aug 23, 2024
Copy link
Contributor

aem-code-sync bot commented Aug 23, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Aug 23, 2024

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (c00c777) to head (48b551f).
Report is 84 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2782      +/-   ##
==========================================
+ Coverage   95.69%   95.89%   +0.19%     
==========================================
  Files         172      173       +1     
  Lines       45379    45853     +474     
==========================================
+ Hits        43424    43969     +545     
+ Misses       1955     1884      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

libs/blocks/aside/aside.js Outdated Show resolved Hide resolved
libs/blocks/aside/aside.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to methomas/aside-tiger August 23, 2024 23:03 Inactive
Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@mokimo mokimo merged commit adb35eb into stage Aug 29, 2024
16 checks passed
@mokimo mokimo deleted the methomas/aside-tiger branch August 29, 2024 14:21
@mokimo mokimo mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? needs-verification PR requires E2E testing by a reviewer Ready for Stage run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants