fix(MWPW-155964):Lana log error type changed to info. #2818

sharath-kannan · 2024-09-03T06:31:51Z

Type of Lana log changed to info.

Test URLs:

aem-code-sync · 2024-09-03T06:32:12Z

	Page	Scores	Audits	Google
M	/?martech=off
D	/?martech=off

codecov · 2024-09-03T06:34:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (510f7a6) to head (7bc712e).
Report is 20 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #2818      +/-   ##
==========================================
+ Coverage   95.87%   96.19%   +0.32%     
==========================================
  Files         173      215      +42     
  Lines       46333    53992    +7659     
==========================================
+ Hits        44421    51940    +7519     
- Misses       1912     2052     +140

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

npeltier · 2024-09-03T07:21:48Z

libs/martech/martech.js

@@ -118,14 +118,14 @@ export const getTargetPersonalization = async () => {
  const responseStart = Date.now();
  window.addEventListener(ALLOY_SEND_EVENT, () => {
    const responseTime = calculateResponseTime(responseStart);
-    window.lana.log(`target response time: ${responseTime}`, { tags: 'errorType=info,module=martech' });
+    window.lana.log(`target response time: ${responseTime}`, { tags: 'module-martech', errorType: 'i' });


is module-martech tag existing? wouldn't martech be clear enough, yet smaller?

yes, I will make this change.

npeltier · 2024-09-03T07:25:47Z

libs/martech/martech.js

  }, { once: true });

  let manifests = [];
  let propositions = [];
  const response = await waitForEventOrTimeout(ALLOY_SEND_EVENT, timeout);
  if (response.error) {
-    window.lana.log('target response time: ad blocker', { tags: 'errorType=info,module=martech' });
+    window.lana.log('target response time: ad blocker', { tags: 'errorType-info,module-martech' });


isn't this not consistent with the above? shouldn't it be
{ tags: 'module-martech', errorType: 'i' } too?

It should be, if the log was informational but since this is clearly inside the error block i have left the errorType to default which is "error".

mm to me "error" is a problem on our side, the fact the browser uses adblocker does not really fall into that category, but i guess i'm fine :)

libs/martech/martech.js

github-actions · 2024-09-04T01:24:08Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

thedoc31

key-value pairs are not supported in the tags. Please refer to https://wiki.corp.adobe.com/display/WCMSOps/LANA+-+Log+Always+Never+Assume#LANALogAlwaysNeverAssume-Parameters for the correct parameters to pass to LANA.

I was wrong, see comment below.

thedoc31

This format should work, per the documentation. Please validate in Splunk that these messages now come in as info type.

robert-bogos

Hi @sharath-kannan ! I think the Jira ticket aimed to correct all the LANA logs that are not being used properly, not just the ones from martech.

sharath-kannan · 2024-09-04T16:20:51Z

Hi @sharath-kannan ! I think the Jira ticket aimed to correct all the LANA logs that are not being used properly, not just the ones from martech.

Okay,I will correct all the lana logs that are used incorrectly in milo and update my PR. Hope using "module-" will be fine for now?

thedoc31 · 2024-09-04T18:08:42Z

Hi @sharath-kannan ! I think the Jira ticket aimed to correct all the LANA logs that are not being used properly, not just the ones from martech.

Okay,I will correct all the lana logs that are used incorrectly in milo and update my PR. Hope using "module-" will be fine for now?

I would recommend making the tags as concise as possible, but a dash character is fine within a comma-delimited list. The restricted characters are documented on the wiki [1] in the note above the table.

[1]
https://wiki.corp.adobe.com/display/WCMSOps/LANA+-+Log+Always+Never+Assume#LANALogAlwaysNeverAssume-Parameters

skumar09 · 2024-09-06T17:54:51Z

@sharath-kannan : can you please update your branch with latest code base( I guess it doesn't have video block changes, as corresponding nala tests are failing)

hparra

It's not clear why we're doing this. Did the LANA interface change? At the time this was correct.

video-metadata is a deprecated component so there is no issue here.

libs/blocks/faas/utils.js

thedoc31 · 2024-09-09T20:59:55Z

It's not clear why we're doing this. Did the LANA interface change? At the time this was correct.

video-metadata is a deprecated component so there is no issue here.

Unfortunately, the information provided at the time was incorrect. Key-value pairs have never been supported in tags: elements. The documentation has been updated to make this very clear.

spadmasa · 2024-09-11T17:49:34Z

Validated the change done in splunk logs
https://main--cc--adobecom.hlx.page/products/photoshop?milolibs=mwpw-155964--milosh--sharath-kannan&lanadebug

* lana log error type changed * modified lana logs * added a few unit tests for lana logs * Updated tag in utils.js * linting error fixed * linting error fix 2 * unit test fix * added unit test for vimeo

lana log error type changed

af61a4a

sharath-kannan requested a review from a team as a code owner September 3, 2024 06:31

npeltier reviewed Sep 3, 2024

View reviewed changes

mokimo reviewed Sep 3, 2024

View reviewed changes

libs/martech/martech.js Outdated Show resolved Hide resolved

JackySun9 added the run-nala Run Nala Test Automation against PR label Sep 3, 2024

thedoc31 requested changes Sep 4, 2024

View reviewed changes

thedoc31 approved these changes Sep 4, 2024

View reviewed changes

robert-bogos reviewed Sep 4, 2024

View reviewed changes

spadmasa self-assigned this Sep 5, 2024

skumar09 added run-nala Run Nala Test Automation against PR and removed run-nala Run Nala Test Automation against PR labels Sep 6, 2024

sharath-kannan and others added 2 commits September 7, 2024 09:21

Merge branch 'adobecom:stage' into MWPW-155964

62c613b

modified lana logs

6934804

sharath-kannan requested review from hparra, meganthecoder, JasonHowellSlavin, Brandon32, colloyd, sabyamon, fullcolorcoder, JackySun9, seanchoi-dev and rgclayton as code owners September 9, 2024 06:28

added a few unit tests for lana logs

c6badb7

hparra approved these changes Sep 9, 2024

View reviewed changes

thedoc31 requested changes Sep 9, 2024

View reviewed changes

libs/blocks/faas/utils.js Outdated Show resolved Hide resolved

Updated tag in utils.js

d28cd97

sharath-kannan requested a review from thedoc31 September 10, 2024 02:50

sharath-kannan added 3 commits September 10, 2024 12:33

linting error fixed

7ae3a57

linting error fix 2

40e4f38

unit test fix

555775c

thedoc31 approved these changes Sep 11, 2024

View reviewed changes

added unit test for vimeo

7bc712e

spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Sep 11, 2024

milo-pr-merge bot merged commit a7c31b7 into adobecom:stage Sep 12, 2024
21 checks passed

milo-pr-merge bot mentioned this pull request Sep 12, 2024

[Release] Stage to Main #2874

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(MWPW-155964):Lana log error type changed to info. #2818

fix(MWPW-155964):Lana log error type changed to info. #2818

sharath-kannan commented Sep 3, 2024

aem-code-sync bot commented Sep 3, 2024 •

edited

Loading

codecov bot commented Sep 3, 2024 •

edited

Loading

npeltier Sep 3, 2024

sharath-kannan Sep 3, 2024

npeltier Sep 3, 2024

sharath-kannan Sep 3, 2024

npeltier Sep 3, 2024

github-actions bot commented Sep 4, 2024

thedoc31 left a comment •

edited

Loading

thedoc31 left a comment

robert-bogos left a comment •

edited

Loading

sharath-kannan commented Sep 4, 2024

thedoc31 commented Sep 4, 2024

skumar09 commented Sep 6, 2024

hparra left a comment

thedoc31 commented Sep 9, 2024

spadmasa commented Sep 11, 2024

fix(MWPW-155964):Lana log error type changed to info. #2818

fix(MWPW-155964):Lana log error type changed to info. #2818

Conversation

sharath-kannan commented Sep 3, 2024

aem-code-sync bot commented Sep 3, 2024 • edited Loading

codecov bot commented Sep 3, 2024 • edited Loading

Codecov Report

npeltier Sep 3, 2024

Choose a reason for hiding this comment

sharath-kannan Sep 3, 2024

Choose a reason for hiding this comment

npeltier Sep 3, 2024

Choose a reason for hiding this comment

sharath-kannan Sep 3, 2024

Choose a reason for hiding this comment

npeltier Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 4, 2024

thedoc31 left a comment • edited Loading

Choose a reason for hiding this comment

thedoc31 left a comment

Choose a reason for hiding this comment

robert-bogos left a comment • edited Loading

Choose a reason for hiding this comment

sharath-kannan commented Sep 4, 2024

thedoc31 commented Sep 4, 2024

skumar09 commented Sep 6, 2024

hparra left a comment

Choose a reason for hiding this comment

thedoc31 commented Sep 9, 2024

spadmasa commented Sep 11, 2024

aem-code-sync bot commented Sep 3, 2024 •

edited

Loading

codecov bot commented Sep 3, 2024 •

edited

Loading

thedoc31 left a comment •

edited

Loading

robert-bogos left a comment •

edited

Loading