Create an onReady and onError callback for standalone gnav

[bandana147]

• Adds an onReady callback that will be triggered when Gnav loads
• Adds an onError callback that will be triggered if any error occurs inside gnav

Resolves: MWPW-158168

Test URLs:

• Before: https://main--milo--adobecom.hlx.page/?martech=off
• After: https://gnav-event--milo--adobecom.hlx.page/?martech=off

Qa: https://adobecom.github.io/nav-consumer/navigation.html?authoringpath=/federal/dev&env=stage&navbranch=gnav-event

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 40b7b0c ✅ (latest)
• 62987f6 ✅
• 493de8e ✅
• e6e537a ✅
• 787cf1a ✅
• 738e644 ✅
• 5cf6df2 ✅
• ae8ab66 ✅
• fe97241 ✅
• 283137c ✅
• f8a01e0 ✅
• e3b81af ✅
• 8e23575 ✅
• 902b388 ✅
• 1551217 ✅
• 3adda9b ✅
• d1c0d14 ✅
• b8f94ae ✅

[aem-code-sync]

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (5ddeb73) to head (40b7b0c).
Report is 4 commits behind head on stage.

Additional details and impacted files

@@           Coverage Diff           @@
##            stage    #2873   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         240      240           
  Lines       54739    54750   +11     
=======================================
+ Hits        52709    52724   +15     
+ Misses       2030     2026    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mokimo]

Suggested change

	window.dispatchEvent(new CustomEvent('feds:nav.ready'));
	window.dispatchEvent(new CustomEvent('feds:nav:ready'));

[mokimo]

On another note, since it's a milo block, should we dispatch milo:globalnav:ready ? That follows the other eventlisteners such as milo:modal:closed within the ecosystem

[mokimo]

As a more general question, why is that needed and what is the use-case? The ticket and description don't mention anything

[bandana147]

As a more general question, why is that needed and what is the use-case? The ticket and description don't mention anything

@mokimo This is currently required for the Adobe Home team, but we thought it would be a good use case to support as a standalone component. They want to display a loader state until the Gnav fully loads and be able to handle/track any errors that occur within their app.

[github-actions]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

[bandana147]

@narcis-radu @mokimo Could you please review the updated changes?

[github-actions]

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

[prativas22]

The following URL on the gnav-event nav branch has been validated after the push; the details
onReady call check:
https://adobecom.github.io/nav-consumer/navigation.html?authoringpath=/federal/dev/gnavtest/ccgnav/photographyshortform&env=stage&navbranch=gnav-event

https://adobecom.github.io/nav-consumer/navigation.html?env=stage&theme=dark&navbranch=gnav-event&authoringpath=/federal/dev&imsclientid=001

https://adobecom.github.io/nav-consumer/navigation.html?authoringpath=/federal/dev/gnavtest/ccgnav/photographyshortform123&env=stage&navbranch=gnav-event&imsclientid=adobedotcom001

[milo-pr-merge]

Skipped 2873: "Create an onReady and onError callback for standalone gnav" due to file "libs/blocks/global-navigation/global-navigation.js" overlap. Merging will be attempted in the next batch