Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-158314 : NALA] Add nala tests for additional marquee variants #2950

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

skumar09
Copy link
Contributor

  • Update console error steps
  • Add test scripts for new marquee variants.
    - Marquee (large, standard) 
    - Marquee (large, compact) 
    - Marquee anchors 
    - Marquee anchors (transparent) 
    - Marquee background image focal point) 

Resolves: MWPW-158314

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Sep 25, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (5ddeb73) to head (fa632e2).
Report is 7 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2950      +/-   ##
==========================================
- Coverage   96.29%   95.97%   -0.32%     
==========================================
  Files         240      175      -65     
  Lines       54739    46861    -7878     
==========================================
- Hits        52709    44977    -7732     
+ Misses       2030     1884     -146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Santoshkumar Sharanappa Nateekar added 2 commits September 24, 2024 23:23
});

// Test 0 : Marquee anchors
test(`[Test Id - ${features[0].tcid}] ${features[0].name},${features[0].tags}`, async ({ page, baseURL }) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Space after comma, before tags.

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 25, 2024

Skipped merging 2950: [MWPW-158314 : NALA] Add nala tests for additional marquee variants due to failing checks

@mokimo
Copy link
Contributor

mokimo commented Sep 26, 2024

There's a bunch of video marquees #2915
and CC has an "interactive marquee" adobecom/cc#413 should we add tests for those as well?

@skumar09
Copy link
Contributor Author

There's a bunch of video marquees #2915 and CC has an "interactive marquee" adobecom/cc#413 should we add tests for those as well?

@mokimo : The video marquee (as part of cc#413) is in progress, and I will add them separately. (will add it as part of the video block )

@mokimo mokimo merged commit 501a373 into adobecom:stage Sep 26, 2024
12 of 14 checks passed
@mokimo mokimo mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants