Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-160011] - GNAV light mode color changes #3019

Merged
merged 10 commits into from
Nov 12, 2024
Merged

[MWPW-160011] - GNAV light mode color changes #3019

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
692a42e
Color changes
Deva309 Oct 8, 2024
eceb28b
Promo background color fix
Deva309 Oct 9, 2024
7368520
Add text and subtext font color changes in megamenu
Deva309 Oct 9, 2024
0bab77d
cross cloud menu background color changes
Deva309 Oct 18, 2024
8cb4ff3
Fix reveiew comments
Deva309 Oct 21, 2024
74ea5e8
resolve conflicts
Deva309 Nov 4, 2024
7f7c396
Merge branch 'stage' of github.com:adobecom/milo into MWPW-160011
Deva309 Nov 5, 2024
c57a657
colors hexcode formatted as lowercase for css variables
Deva309 Nov 5, 2024
60ff144
Merge branch 'stage' of github.com:adobecom/milo into MWPW-160011
Deva309 Nov 8, 2024
d1a5876
Bug fix MWPW-161889
Deva309 Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions libs/blocks/global-navigation/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
--feds-height-breadcrumbs: 33px;
--feds-gutter: 8px;
/* Top navigation - backgrounds */
--feds-background-nav: #fff;
--feds-background-popup: #fafafa;
--feds-background-nav: #f8f8f8;
--feds-background-popup: #f3f3f3;
--feds-background-promo: #fff;
--feds-background-promo--dark: #000;
/* Top navigation - borders */
--feds-borderColor: #eaeaea;
Expand All @@ -23,11 +24,11 @@
/* Top navigation - misc */
--feds-radius-utilityIcon: 4px;
/* Links */
--feds-background-link--hover: #f5f5f5;
--feds-borderColor-link: #f3f3f3;
--feds-color-link: #2c2c2c;
--feds-color-link--hover: #1473e6;
--feds-color-navLink-description: #656565;
--feds-background-link--hover: #e9e9e9;
--feds-borderColor-link: #e9e9e9;
--feds-color-link: #292929;
--feds-color-link--hover: #274DEA;
Deva309 marked this conversation as resolved.
Show resolved Hide resolved
--feds-color-navLink-description: #505050;
--feds-color-link-breadcrumbs: #707070;
/* Footer */
--feds-background-footer: #fafafa;
Expand Down
3 changes: 2 additions & 1 deletion libs/blocks/global-navigation/dark-nav.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
--feds-borderColor: #303030;
--feds-borderColor-menu: #4B4B4B;
--feds-borderColor-navLink: #DBDBDB;
--feds-background-promo: #1D1D1D;
Deva309 marked this conversation as resolved.
Show resolved Hide resolved
/* Top navigation - colors */
--feds-color-adobeBrand: #FFF;
--feds-color-headline--mobile: #F2F2F2;
Expand Down Expand Up @@ -166,7 +167,7 @@
@media (min-width: 900px) {
.feds--dark .feds-promo {
border: 1px solid var(--feds-borderColor);
background: #1D1D1D;
background: var(--feds-background-promo);
}

.feds--dark .feds-promo--dark,
Expand Down
10 changes: 5 additions & 5 deletions libs/blocks/global-navigation/global-navigation.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,15 +250,15 @@ header.global-navigation {
}

.feds-cta--primary {
background-color: rgb(20, 115, 230);
border-color: rgb(20, 115, 230);
background-color: rgb(59, 99, 251);
border-color: rgb(59, 99, 251);
color: rgb(255, 255, 255);
}

.feds-cta--primary:hover,
.feds-cta--primary:focus {
background-color: rgb(13, 102, 208);
border-color: rgb(13, 102, 208);
background-color: rgb(39, 77, 234);
border-color: rgb(39, 77, 234);
color: rgb(255, 255, 255);
}

Expand Down Expand Up @@ -665,7 +665,7 @@ header.global-navigation {
right: 0;
justify-content: center;
border-bottom: unset;
box-shadow: 0 3px 2px rgb(142 142 142 / 30%);
border-bottom: 1px solid var(--feds-borderColor);
background: var(--feds-background-nav);
transform: translate3d(0,0,0); /* Fix Safari issues w/ position: sticky */
}
Expand Down
6 changes: 3 additions & 3 deletions libs/blocks/global-navigation/utilities/menu/menu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
flex-direction: column;
width: 100%;
border: 1px solid var(--feds-borderColor);
background: var(--feds-background-nav);
background: var(--feds-background-promo);
white-space: normal;
box-sizing: content-box;
}
Expand Down Expand Up @@ -223,8 +223,8 @@
width: 100%;
display: flex;
justify-content: center;
border-top: solid 1px #f3f3f3;
background-color: #fff;
border-top: solid 1px var(--feds-borderColor);
background-color: var(--feds-background-nav);
}

.feds-crossCloudMenu {
Expand Down
16 changes: 11 additions & 5 deletions libs/navigation/navigation.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
/* Extracting the essential styles required for rendering the component independently */
.global-navigation, .global-footer, .dialog-modal {
:root {
--navigation-link-color: #035FE6;
--navigation-link-color--hover: #136FF6;
}

.global-navigation, .global-footer, .dialog-modal {
font-family: 'Adobe Clean', adobe-clean, 'Trebuchet MS', sans-serif;
line-height: 27px;
color: #2c2c2c;
Expand All @@ -12,7 +17,7 @@
}

.dialog-modal a {
color: #035FE6;
color: var(--navigation-link-color);
}

.global-navigation img, .global-footer img {
Expand All @@ -31,12 +36,13 @@ header.global-navigation, header.global-navigation.feds--dark {

@media (min-width: 900px) {
.feds-promo-link {
color: #035FE6;
color: var(--navigation-link-color);
}

.feds-promo-link:hover {
color: #136FF6;
color: var(--navigation-link-color--hover);
}

.feds--full-width .feds-topnav {
max-width: none;
padding: 0 15px;
Expand Down
Loading