[MWPW-159905] - Add config for full width and no border along with jarvis fix for standalone GNAV #3020

Deva309 · 2024-10-08T13:05:22Z

Things covered as part of this PR:

Add config as layout for supporting full width in Standalone GNAV.
Add config for noBorder for removing border for adobe home.
Relative url href removal added for custom Links
Add Jarvis call for standalone GNAV

Test URLs:

QA:

aem-code-sync · 2024-10-08T13:05:49Z

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

codecov · 2024-10-08T13:07:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (1bdfd4a) to head (5477bc7).
Report is 23 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #3020      +/-   ##
==========================================
+ Coverage   96.34%   96.41%   +0.07%     
==========================================
  Files         243      243              
  Lines       55284    55475     +191     
==========================================
+ Hits        53261    53485     +224     
+ Misses       2023     1990      -33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bandana147 · 2024-10-08T13:49:57Z

libs/navigation/navigation.js

@@ -4,7 +4,7 @@ const blockConfig = [
    name: 'global-navigation',
    targetEl: 'header',
    appendType: 'prepend',
-    params: ['imsClientId', 'searchEnabled', 'unav', 'customLinks', 'jarvis'],
+    params: ['imsClientId', 'searchEnabled', 'unav', 'customLinks', 'jarvis', 'layout'],


You don't need to pass the param layout since it is not used in the block code through milo configs.

Done removed from params.

bandana147 · 2024-10-10T05:44:59Z

libs/navigation/bootstrapper.js

  const { getConfig, createTag, loadLink, loadScript } = await import(`${miloLibs}/utils/utils.js`);
  const { default: initBlock } = await import(`${miloLibs}/blocks/${name}/${name}.js`);

  const styles = [`${miloLibs}/blocks/${name}/${name}.css`, `${miloLibs}/navigation/navigation.css`];
  styles.forEach((url) => loadLink(url, { rel: 'stylesheet' }));

+  const setNavLayout = () => {
+    const element = document.querySelector(targetEl);
+    if (element && layout === 'fullWidth') {


The element will always exist, so I believe we can skip the element check here.

yes correct, removed element check condition.

github-actions · 2024-10-15T01:37:44Z

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

spadmasa · 2024-10-15T03:22:25Z

Validation done on the pr :
https://adobecom.github.io/nav-consumer/navigation.html?env=stage&navbranch=mwpw-159905&authoringpath=/federal/test-website&layout=fullWidth

https://adobecom.github.io/nav-consumer/navigation.html?env=stage&navbranch=mwpw-159905&authoringpath=/federal/test-website&layout=fullWidth&noborder=true

https://adobecom.github.io/nav-consumer/navigation.html?env=stage&navbranch=mwpw-159905&authoringpath=/federal/dev/soujanya&layout=fullWidth&noborder=true&customlinks=home,apps,learn,files,discover

Validation done on the below urls
https://adobecom.github.io/nav-consumer/navigation.html?env=stage&navbranch=mwpw-159905&authoringpath=/federal/home

In standalone gnav able to test that it should redirect to helpx support as jarvis is not initialized , can be tested on adobe home once change is deployed to their env
Verified the jarvis flow in branch url
https://main--cc--adobecom.hlx.live/creativecloud?milolibs=mwpw-159905--milo--deva309

https://main--homepage--adobecom.hlx.page/homepage/index-loggedout?milolibs=mwpw-159905--milo--deva309

Add config for full width Standalone GNAV

0cc457b

lint fix

aa486c7

aem-code-sync bot temporarily deployed to MWPW-159905 October 8, 2024 13:11 Inactive

Deva309 requested review from bandana147, salonijain3, sharmrj, nishantka, sonawanesnehal3 and akanshaa-18 October 8, 2024 13:14

spadmasa assigned spadmasa and prativas22 Oct 8, 2024

UT coverage

d4dd6d2

aem-code-sync bot temporarily deployed to MWPW-159905 October 8, 2024 13:26 Inactive

bandana147 reviewed Oct 8, 2024

View reviewed changes

sharmrj approved these changes Oct 8, 2024

View reviewed changes

fix reveiw comment

523ec50

aem-code-sync bot temporarily deployed to MWPW-159905 October 9, 2024 03:57 Inactive

Deva309 requested a review from bandana147 October 9, 2024 04:03

Deva309 added 2 commits October 9, 2024 13:37

Make GNAV border bottom configurable for standalone GNAV

c04e96f

UT added

e0d74b0

aem-code-sync bot temporarily deployed to MWPW-159905 October 9, 2024 08:14 Inactive

bandana147 reviewed Oct 10, 2024

View reviewed changes

relative url AED disable for custom links

6f1d80a

aem-code-sync bot temporarily deployed to MWPW-159905 October 10, 2024 06:16 Inactive

Fix review comment

dffacb0

aem-code-sync bot temporarily deployed to MWPW-159905 October 10, 2024 06:17 Inactive

Deva309 requested a review from bandana147 October 10, 2024 06:23

relative url AED disable for custom links

23711d3

aem-code-sync bot temporarily deployed to MWPW-159905 October 10, 2024 08:58 Inactive

bandana147 approved these changes Oct 14, 2024

View reviewed changes

fix active link href

68c6e93

aem-code-sync bot temporarily deployed to MWPW-159905 October 14, 2024 11:17 Inactive

UT

5a3d94f

aem-code-sync bot temporarily deployed to MWPW-159905 October 14, 2024 11:40 Inactive

spadmasa added the verified PR has been E2E tested by a reviewer label Oct 15, 2024

bandana147 mentioned this pull request Oct 17, 2024

Standalone Gnav changes - Grey bg color, Auto stage link conversion, full width, search container and Jarvis chat through gnav #3058

Closed

Added jarvis fix in this PR

5477bc7

aem-code-sync bot deployed to MWPW-159905 October 21, 2024 13:54 View deployment

Deva309 mentioned this pull request Oct 21, 2024

"Contact Us" CTA takes user to a URL which doesnt open Jarvis chatbot as expected #3057

Closed

salonijain3 approved these changes Oct 21, 2024

View reviewed changes

Deva309 changed the title ~~[MWPW-159905] - Add config for full width Standalone GNAV~~ [MWPW-159905] - Add config for full width and no border along with jarvis fix for standalone GNAV Oct 21, 2024

spadmasa added the Ready for Stage label Oct 22, 2024

milo-pr-merge bot merged commit 63ff041 into adobecom:stage Oct 22, 2024
18 checks passed

milo-pr-merge bot mentioned this pull request Oct 22, 2024

[Release] Stage to Main #3072

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MWPW-159905] - Add config for full width and no border along with jarvis fix for standalone GNAV #3020

[MWPW-159905] - Add config for full width and no border along with jarvis fix for standalone GNAV #3020

Deva309 commented Oct 8, 2024 •

edited

Loading

aem-code-sync bot commented Oct 8, 2024 •

edited

Loading

codecov bot commented Oct 8, 2024 •

edited

Loading

bandana147 Oct 8, 2024

Deva309 Oct 9, 2024

bandana147 Oct 10, 2024

Deva309 Oct 10, 2024

github-actions bot commented Oct 15, 2024

spadmasa commented Oct 15, 2024 •

edited

Loading

[MWPW-159905] - Add config for full width and no border along with jarvis fix for standalone GNAV #3020

[MWPW-159905] - Add config for full width and no border along with jarvis fix for standalone GNAV #3020

Conversation

Deva309 commented Oct 8, 2024 • edited Loading

aem-code-sync bot commented Oct 8, 2024 • edited Loading

codecov bot commented Oct 8, 2024 • edited Loading

Codecov Report

bandana147 Oct 8, 2024

Choose a reason for hiding this comment

Deva309 Oct 9, 2024

Choose a reason for hiding this comment

bandana147 Oct 10, 2024

Choose a reason for hiding this comment

Deva309 Oct 10, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 15, 2024

spadmasa commented Oct 15, 2024 • edited Loading

Deva309 commented Oct 8, 2024 •

edited

Loading

aem-code-sync bot commented Oct 8, 2024 •

edited

Loading

codecov bot commented Oct 8, 2024 •

edited

Loading

spadmasa commented Oct 15, 2024 •

edited

Loading