Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-159561 Add lcpSectionOne metric to web vitals #3044

Merged
merged 2 commits into from
Oct 30, 2024
Merged

MWPW-159561 Add lcpSectionOne metric to web vitals #3044

merged 2 commits into from
Oct 30, 2024

Conversation

chrischrischris
Copy link
Contributor

Logs if the LCP Element is in Section One of the page.

Resolves: MWPW-159561

Test URLs:

@chrischrischris
MWPW-159561 Add lcpSectionOne metric
92b8cb7 
Logs if the LCP Element is in Section One of the page.
@chrischrischris chrischrischris requested a review from a team as a code owner October 15, 2024 18:58
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Oct 15, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@chrischrischris chrischrischris changed the title MWPW-159561 Add lcpSectionOne metric MWPW-159561 Add lcpSectionOne metric to web vitals Oct 15, 2024
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Oct 15, 2024 •
edited
Loading

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (ec48f3c) to head (f36395e).
Report is 62 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #3044      +/-   ##
==========================================
+ Coverage   96.34%   96.44%   +0.09%     
==========================================
  Files         243      245       +2     
  Lines       55284    55731     +447     
==========================================
+ Hits        53261    53747     +486     
+ Misses       2023     1984      -39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@SilviuLCF SilviuLCF self-requested a review October 16, 2024 08:06
SilviuLCF
SilviuLCF approved these changes Oct 16, 2024
View reviewed changes
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified , ready to stage
Testing details : https://jira.corp.adobe.com/browse/MWPW-159561

overmyheadandbody
overmyheadandbody approved these changes Oct 16, 2024
View reviewed changes
libs/utils/logWebVitals.js Outdated Show resolved Hide resolved
libs/utils/logWebVitals.js Show resolved Hide resolved
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Oct 23, 2024

Skipped merging 3044: MWPW-159561 Add lcpSectionOne metric to web vitals due to failing checks

3 similar comments
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Oct 28, 2024

Skipped merging 3044: MWPW-159561 Add lcpSectionOne metric to web vitals due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Oct 29, 2024

Skipped merging 3044: MWPW-159561 Add lcpSectionOne metric to web vitals due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Oct 30, 2024

Skipped merging 3044: MWPW-159561 Add lcpSectionOne metric to web vitals due to failing checks

@milo-pr-merge milo-pr-merge bot merged commit 8f0adc1 into stage Oct 30, 2024
14 checks passed
@milo-pr-merge milo-pr-merge bot deleted the mwpw-159561 branch October 30, 2024 20:11
@milo-pr-merge milo-pr-merge bot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokimo mokimo mokimo approved these changes

@sukamat sukamat sukamat approved these changes

@SilviuLCF SilviuLCF SilviuLCF approved these changes

@overmyheadandbody overmyheadandbody overmyheadandbody approved these changes

@rgclayton rgclayton rgclayton approved these changes

Assignees
No one assigned
Labels
Ready for Stage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrischrischris @rgclayton @overmyheadandbody @SilviuLCF @mokimo @sukamat