Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-156940 AU ABM price display #3065

Closed
wants to merge 20 commits into from

Conversation

Copy link
Contributor

aem-code-sync bot commented Oct 18, 2024

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (c61c4d6) to head (93f93d0).
Report is 18 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3065      +/-   ##
==========================================
+ Coverage   96.43%   96.44%   +0.01%     
==========================================
  Files         245      245              
  Lines       55746    55812      +66     
==========================================
+ Hits        53757    53828      +71     
+ Misses       1989     1984       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bozojovicic bozojovicic changed the title Mwpw156940auabm MWPW-156940 AU ABM price display Oct 18, 2024
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@bozojovicic bozojovicic marked this pull request as ready for review October 26, 2024 18:57
Copy link
Contributor

@npeltier npeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed offline @bozojovicic i would like to see some attempt to move AU style & logic mess up in dedicated files, and so leave (most) of merch logic alone, and not touch hero & table blocks

@npeltier
Copy link
Contributor

also @bozojovicic could you create AU draft so we can see before/after ;) ?

@bozojovicic
Copy link
Contributor Author

Opened new PR #3115
Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants