-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-157460 Allow Ungated Marketo One Page Experience #3071
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3071 +/- ##
==========================================
+ Coverage 96.40% 96.43% +0.02%
==========================================
Files 243 245 +2
Lines 55415 55759 +344
==========================================
+ Hits 53425 53771 +346
+ Misses 1990 1988 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Some small nits.
Might be good to have a test that shows the triggered catch
statement from your showSuccessSection function that occurs on line 118 marketo/marketo.js
@JasonHowellSlavin Good point. I decided to remove the try/catch in favor of catching the errors in if statements - less nested and made more sense with the setInterval code. Added tests for those two use cases. |
Co-authored-by: Brandon Marshall <bmarshal@adobe.com>
Reminder to set the |
Add query parameter
?form=off
to any Marketo One Page Experience url to bypass the form. The form won't show up, and instead, the content (video, pdf, etc) will be immediately visible.Resolves: MWPW-157460
Test URLs: