Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157460 Allow Ungated Marketo One Page Experience #3071

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

meganthecoder
Copy link
Contributor

@meganthecoder meganthecoder commented Oct 21, 2024

  • Allows "Ungated" One Page Experience for Marketo
  • [Cleanup] Updates Marketo lana logs to correct format

Add query parameter ?form=off to any Marketo One Page Experience url to bypass the form. The form won't show up, and instead, the content (video, pdf, etc) will be immediately visible.

Resolves: MWPW-157460

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Oct 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Oct 21, 2024

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (332c3a5) to head (6ad9111).
Report is 48 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3071      +/-   ##
==========================================
+ Coverage   96.40%   96.43%   +0.02%     
==========================================
  Files         243      245       +2     
  Lines       55415    55759     +344     
==========================================
+ Hits        53425    53771     +346     
+ Misses       1990     1988       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meganthecoder meganthecoder added run-nala Run Nala Test Automation against PR @marketo Run Marketo Block Tests labels Oct 21, 2024
@meganthecoder
Copy link
Contributor Author

meganthecoder commented Oct 21, 2024

Copy link
Contributor

@JasonHowellSlavin JasonHowellSlavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some small nits.

Might be good to have a test that shows the triggered catch statement from your showSuccessSection function that occurs on line 118 marketo/marketo.js

libs/blocks/marketo/marketo.js Outdated Show resolved Hide resolved
libs/blocks/marketo/marketo.js Outdated Show resolved Hide resolved
test/blocks/marketo/marketo.test.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to methomas/one-page-ungated October 22, 2024 00:08 Inactive
@meganthecoder
Copy link
Contributor Author

Might be good to have a test that shows the triggered catch statement from your showSuccessSection function that occurs on line 118 marketo/marketo.js

@JasonHowellSlavin Good point. I decided to remove the try/catch in favor of catching the errors in if statements - less nested and made more sense with the setInterval code. Added tests for those two use cases.

@aem-code-sync aem-code-sync bot temporarily deployed to methomas/one-page-ungated October 22, 2024 00:17 Inactive
Co-authored-by: Brandon Marshall <bmarshal@adobe.com>
@aem-code-sync aem-code-sync bot temporarily deployed to methomas/one-page-ungated October 22, 2024 18:15 Inactive
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@JackySun9 JackySun9 added verified PR has been E2E tested by a reviewer Ready for Stage labels Oct 29, 2024
@milo-pr-merge milo-pr-merge bot merged commit 7255d63 into stage Oct 30, 2024
22 checks passed
@milo-pr-merge milo-pr-merge bot deleted the methomas/one-page-ungated branch October 30, 2024 17:35
@milo-pr-merge milo-pr-merge bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@marketo Run Marketo Block Tests Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants