Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161130 - [Table] Handle dynamic pricing in addon labels #3100

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

Sartxi
Copy link
Contributor

@Sartxi Sartxi commented Oct 28, 2024

When adding dynamic prices in the table blocks new addon feature the dynamic price element is rendered in the flex grid instead of inline with the text content. Fixing this issue by separating out the icon element and grouping all other authored content in addon labels.

Resolves: MWPW-161130

Test URLs:

@Sartxi Sartxi added bug Something isn't working high priority Why is this a high priority? Blocker? Critical? Dependency? labels Oct 28, 2024
Copy link
Contributor

aem-code-sync bot commented Oct 28, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Oct 28, 2024

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (8f0adc1) to head (e1cee36).
Report is 16 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3100      +/-   ##
==========================================
+ Coverage   96.34%   96.35%   +0.01%     
==========================================
  Files         245      245              
  Lines       56316    56375      +59     
==========================================
+ Hits        54256    54321      +65     
+ Misses       2060     2054       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-161130-table October 29, 2024 18:42 Inactive
Copy link
Contributor

@robert-bogos robert-bogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sartxi ! Are the failing unit tests related to your changes?

@Sartxi
Copy link
Contributor Author

Sartxi commented Oct 30, 2024

Hi @Sartxi ! Are the failing unit tests related to your changes?

I was able to get it passing by rebasing with Stage!

@Sartxi Sartxi added the verified PR has been E2E tested by a reviewer label Oct 30, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-161130-table October 30, 2024 20:45 Inactive
Copy link
Contributor

@robert-bogos robert-bogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@NadiiaSokolova NadiiaSokolova self-assigned this Nov 6, 2024
Copy link

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-161130

@milo-pr-merge milo-pr-merge bot merged commit 23e4df5 into stage Nov 6, 2024
19 checks passed
@milo-pr-merge milo-pr-merge bot deleted the sartxi/MWPW-161130-table branch November 6, 2024 09:17
@milo-pr-merge milo-pr-merge bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants