-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-161130 - [Table] Handle dynamic pricing in addon labels #3100
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3100 +/- ##
==========================================
+ Coverage 96.34% 96.35% +0.01%
==========================================
Files 245 245
Lines 56316 56375 +59
==========================================
+ Hits 54256 54321 +65
+ Misses 2060 2054 -6 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Sartxi ! Are the failing unit tests related to your changes?
I was able to get it passing by rebasing with Stage! |
…MWPW-161130-table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Reminder to set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-161130
When adding dynamic prices in the table blocks new addon feature the dynamic price element is rendered in the flex grid instead of inline with the text content. Fixing this issue by separating out the icon element and grouping all other authored content in addon labels.
Resolves: MWPW-161130
Test URLs: