Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161191: Checkout cli parameter does not get rendered correctly #3108

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

Axelcureno
Copy link
Member

@Axelcureno Axelcureno commented Oct 29, 2024

@Axelcureno Axelcureno added run-nala Run Nala Test Automation against PR commerce needs-verification PR requires E2E testing by a reviewer labels Oct 29, 2024
@Axelcureno Axelcureno self-assigned this Oct 29, 2024
@Axelcureno Axelcureno requested a review from a team as a code owner October 29, 2024 19:54
Copy link
Contributor

aem-code-sync bot commented Oct 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (34e21ad) to head (52ea5e2).
Report is 7 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3108   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         247      247           
  Lines       56235    56252   +17     
=======================================
+ Hits        54176    54193   +17     
  Misses       2059     2059           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

aem-code-sync bot commented Oct 29, 2024

@Roycethan Roycethan added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Oct 29, 2024
Copy link

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Axelcureno Its breaking Pricing and Checkout CTA's (label and commerce url) at CC pages:
https://main--cc--adobecom.hlx.live/creativecloud?milolibs=MWPW-161191--milo--adobecom
image

cc @yesil @npeltier @afmicka @3ch023

@Roycethan
Copy link

@Axelcureno Its breaking Pricing and Checkout CTA's (label and commerce url) at CC pages: https://main--cc--adobecom.hlx.live/creativecloud?milolibs=MWPW-161191--milo--adobecom image

cc @yesil @npeltier @afmicka @3ch023

@Axelcureno Fixed now with latest commit. Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@Roycethan Roycethan added the verified PR has been E2E tested by a reviewer label Oct 29, 2024
@Roycethan
Copy link

@Axelcureno Verified, Need 2 approvals for Ready for stage label, and if there any changes a smoke test. Thanks

// eslint-disable-next-line no-prototype-builtins
if (commerce?.hasOwnProperty(camelCaseAttr)) {
const value = commerce[camelCaseAttr];
delete commerce[camelCaseAttr];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not alter commerce object.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those attributes could be added through attributes object

'checkout-workflow-step',
'force-tax-exclusive',
'checkout-client-id',
'allow-override',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow-override is not controlled by the consumer but by merch.js, and it is set only for non prod domains.
we should remove it from the list.

Copy link
Contributor

@npeltier npeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i generally agree with @yesil feedbacks, but this can be treated afterward

Copy link
Contributor

@yesil yesil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my feedback can be addressed later.

@Roycethan Roycethan added Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Oct 30, 2024
@milo-pr-merge milo-pr-merge bot merged commit 7c6a043 into stage Oct 30, 2024
23 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-161191 branch October 30, 2024 17:35
@milo-pr-merge milo-pr-merge bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants