-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-161191: Checkout cli parameter does not get rendered correctly #3108
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3108 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 247 247
Lines 56235 56252 +17
=======================================
+ Hits 54176 54193 +17
Misses 2059 2059 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Axelcureno Its breaking Pricing and Checkout CTA's (label and commerce url) at CC pages:
https://main--cc--adobecom.hlx.live/creativecloud?milolibs=MWPW-161191--milo--adobecom
@Axelcureno Fixed now with latest commit. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
@Axelcureno Verified, Need 2 approvals for Ready for stage label, and if there any changes a smoke test. Thanks |
// eslint-disable-next-line no-prototype-builtins | ||
if (commerce?.hasOwnProperty(camelCaseAttr)) { | ||
const value = commerce[camelCaseAttr]; | ||
delete commerce[camelCaseAttr]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not alter commerce
object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those attributes could be added through attributes object
'checkout-workflow-step', | ||
'force-tax-exclusive', | ||
'checkout-client-id', | ||
'allow-override', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allow-override
is not controlled by the consumer but by merch.js, and it is set only for non prod domains.
we should remove it from the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i generally agree with @yesil feedbacks, but this can be treated afterward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my feedback can be addressed later.
Fixes CLI parameter in checkout links in milo consumer projects like DC, CC.
Resolves: MWPW-161191
Actual test URL (needs to be tested from milo consumer project): https://main--dc--adobecom.hlx.live/acrobat/features?milolibs=MWPW-161191--milo--adobecom
Test URLs: