MWPW-160966 Fix next-gen sidekick preflight #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3126 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 245 245
Lines 56316 56316
=======================================
Hits 54261 54261
Misses 2055 2055 ☔ View full report in Codecov by Sentry. |
mokimo
approved these changes
Nov 1, 2024
Brandon32
approved these changes
Nov 1, 2024
|
Reminder to set the |
narcis-radu
approved these changes
Nov 7, 2024
| ? aemSk.shadowRoot.querySelector('plugin-action-bar').shadowRoot.querySelector('sk-action-button.publish') | ||
| : hlxSk.shadowRoot.querySelector('div.publish.plugin button'); | ||
|
|
||
| publishBtn.addEventListener('click', () => { |
There was a problem hiding this comment.
nit: this can be a single row
Suggested change
| publishBtn.addEventListener('click', () => { | |
| publishBtn?.addEventListener('click', sendResults); |
JackySun9
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-160966
Test URLs:
Note: Next-Gen sidekick is required to test