[Release] Stage to Main #3187
Merged
[Release] Stage to Main #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![milo-pr-merge[bot]](https://avatars.githubusercontent.com/u/95242840?s=60&v=4){kind=small}
* MWPW-161289 Catalog CTA IMS country used in commerce calls * Trigger Build * MWPW-161289 Catalog CTA IMS country used in commerce calls * MWPW-161289 Catalog CTA IMS country used in commerce calls - commerce re-generated * Trigger Build * Trigger Build * MWPW-161289 Catalog CTA IMS country used in commerce calls * MWPW-161289 Catalog CTA IMS country used in commerce calls * Trigger Build * Expired test promo fixed * Expired test promo fixed * Trigger Build * Trigger Build * New commerce build * Expired test promo rollback * New commerce build * Trigger Build * Trigger Build * New mas build * New mas and commerce build --------- Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
* Helix 5 support for milo blocks and features * Fix the failing unit test * Fix personalization nala tests * Update libs/blocks/quiz-entry/quiz-entry.css Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> * Embed Rares' PR feedback * Account for authored paths to include either .hlx. or .aem. * Remove trailing space * Properly decorate metadata for both hlx4 and hlx5 * Simplify configs * Add separate privacy ids for hlx and aem * Adapt codecov patches to hit the threshhold at 90% --------- Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com>
|
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
milo-pr-merge
bot
requested review from
chrischrischris,
ryanmparrish,
colloyd,
fullcolorcoder,
JackySun9,
a team,
Brandon32,
meganthecoder,
JasonHowellSlavin,
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309,
sonawanesnehal3,
Sartxi and
hparra
as code owners
|
|
@mokimo could you help check this for CAAS: https://stage--milo--adobecom.hlx.live/fragments/caas/test-pages/textcardcollection ,images are missing |
Roycethan
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
tedAir
requested review from
tedAir
and removed request for
a team,
nishantka and
sonawanesnehal3
tedAir
approved these changes
Nov 13, 2024
JackySun9
approved these changes
Nov 13, 2024
JackySun9
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
JackySun9
requested changes
Nov 13, 2024
There was a problem hiding this comment.
hold this for CAAS with helix 5, tracking at https://jira.corp.adobe.com/browse/MWPW-162425
Dli3
approved these changes
Nov 14, 2024
|
Detected the issue, this would just be happening on milo .page and .live pages, so ideally it wouldn't have affected production #3195 |
* add nala folder to mep folder * add observer for the body element * rename once * add css * new folder * same name, same file, different folder * cleanup --------- Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: vgoodric <vgoodric@adobe.com>
JackySun9
approved these changes
Nov 14, 2024
overmyheadandbody
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: