Merge stage into main #3189
Merged
Merge stage into main #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Color changes * Promo background color fix * Add text and subtext font color changes in megamenu * cross cloud menu background color changes * Fix reveiew comments * colors hexcode formatted as lowercase for css variables * Bug fix MWPW-161889
…updating href (#3142) * MWPW-161590 [MEP] Update placeholders before updating href * unit test updates * MWPW-161871 [MEP] useblockcode action fails if page is on milo site (#3161) * stash * ready to publish * interact call coming back but timing out * working on a fast connection * clean up ifs * working with promise * use camel case on let variable * unit tests * update unit tests * MWPW-149504 [MILO][MEP] Move entitlements object to the same JSON file used by the library (#3047) * create mepxlg branch * update library * require full hostname match * update reference for unit test * switch to use config instead of domain list and stub response in unit test * update fetch to 2 * updating another fetch to 2 * restore normalizePath to use preview domains on preview links * preload segment list json * use getFederatedUrl instead * import at top so we don't have to make normalizePath async * MWPW-148129 [MILO][MEP][GNAV] Able to use select by url feature with federated link (#3064) * add federated link function to registerInBlockActions * add to unit test * add unit test coverage * initial commit * Fix useblock code issue --------- Co-authored-by: vgoodric <vgoodric@adobe.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> * MWPW-161606 [MEP] Modify within modals with MEP (#3171) initial commit publish Co-authored-by: viloria <viloria@adobe.com> * add conditionals --------- Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com> Co-authored-by: viloria <viloria@adobe.com>
* Added logo changes for older GNAV experience * Lint Fix * Logo alighned to left for older GNAV
* Use schedule as source for CDT * seperate start and end * Added unit tests
…g plans section (#3103) * remive tabindex=0 as the attributes from merchcard div * fresh commit with same changes as commit 1 after resolving the merge conflict * Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added. * Revert "Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added." This reverts commit 610807a. * run build in mas * run build --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com>
* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * [MWPW-159903] Fix quiz video marquees (#3009) (#3013) fix quiz marquees * [MWPW-159328] handle a case where there are not placeholders availabl… (#3014) [MWPW-159328] handle a case where there are not placeholders available (#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * MWPW-146211 [MILO][MEP] Option to select all elements (#2976) (#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> * MWPW-158455: Promobar overlays with localnav elements in devices (#2991) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Akansha Arora <> * Replaces CSS 'body *' with '.consonant-Wrapper *' --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com>
* relative urls caas support * added unit tests
Fix for verticle alignment of logo
* a links underline, a.quite added * added styles to omit header/footer * added default link styles for headlines and lockup area * minor :hover style alignment on cards-horiz, marquee-anchors, brick * removed dubs underline on links * removed styles overrides to support double in horiz-card, marquee-anch, brick * [MWPW-145672] Remove Gnav global link styles * [MWPW-161624] Link farm double underline on focus * Ensure sub text in anchors is underlined correctly * Ensure sub text in anchors is underlined correctly --------- Co-authored-by: thi64146 <thi64146@adobe.com>
mokimo
requested review from
ryanmparrish,
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309,
sonawanesnehal3 and
chrischrischris
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3189 +/- ##
==========================================
- Coverage 98.46% 96.37% -2.10%
==========================================
Files 68 245 +177
Lines 8167 56598 +48431
==========================================
+ Hits 8042 54548 +46506
- Misses 125 2050 +1925 ☔ View full report in Codecov by Sentry. |
|
vhargrave
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #3181 into main and DO NOT SQUASH. The diff is misleading, this has already been merged but git doesn't correctly identify the commits. If you do a few spot checks, the files already match what's on main.
Milo: