[Release] Stage to Main #3200

milo-pr-merge · 2024-11-14T17:30:46Z

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

add two up mobile variant

…3105) * added support for dynamic-height class * restricted width on large screens

* MWPW-161170: Multiple UI CCD Slice/suggested merch card fixes * updated deps * fixed width on slice card * wide width body s * changes to ccd gallery * Update ccd.html * strikethrough color fixed * Update ccd.html * strikethrough color ccd slice * strikethrough styles * fixed style * correct color var values * cta size m for suggested cards * correct padding * proper dimensions for cards * updated padding * more pixel perfect styles * fixed padding * updated deps * Updated styles * dark body-xs * correct padding * Update variant-layout.js * fixed styles * Add min-width styling to cta links in ccd-suggested variant * Reduce padding-top for body-xs in ccd-suggested variant * Update ccd-suggested variant width to 305px * Update ccd-slice variant styles to use max-width and max-height properties * Add dark theme styles for ccd-suggested variant CTA links * Update dark theme styles for ccd-suggested variant to target outline buttons * Refactor ccd-suggested variant styles for improved responsiveness and consistency * Add gap spacing to ccd-suggested variant for improved layout consistency * Update merch-card body styles to apply consistent color across all sizes

* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * [MWPW-159903] Fix quiz video marquees (#3009) (#3013) fix quiz marquees * [MWPW-159328] handle a case where there are not placeholders availabl… (#3014) [MWPW-159328] handle a case where there are not placeholders available (#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * MWPW-146211 [MILO][MEP] Option to select all elements (#2976) (#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> * MWPW-158455: Promobar overlays with localnav elements in devices (#2991) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Akansha Arora <> * MWPW-160237: Caas Bulk Publisher v2 (Beta) * Fixes ESLint errors * Fixes ESLint errors II * Fixes ESLint errors III * Fixes ESLint errors IV * Fixes ESLint errors V * Renames variables * Fixes ESLint errors -- finaly --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com>

…3193) Initial checkin. Replace Fragment placeholders.

milo-pr-merge · 2024-11-14T17:30:47Z

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

aem-code-sync · 2024-11-14T17:30:51Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

6f4d98c ✅ (latest)
0e407ec ✅
c834273 ✅
499b688 ✅
08fac6a ✅
d19376d ✅

aem-code-sync · 2024-11-14T17:31:12Z

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0e407ecc441064a015065294884233cc72cf8115/libs/features/mas/web-components/src/variants/ccd-suggested.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0e407ecc441064a015065294884233cc72cf8115/libs/features/mas/web-components/src/variants/variant-layout.js

github-actions · 2024-11-14T17:32:38Z

libs/deps/mas/commerce.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T17:32:39Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T17:32:40Z

libs/deps/mas/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T17:32:41Z

libs/features/mas/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T17:32:42Z

libs/features/mas/web-components/src/global.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T17:32:43Z

libs/features/mas/web-components/src/hydrate.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T17:32:43Z

libs/features/mas/web-components/src/merch-card.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T17:32:44Z

libs/features/mas/web-components/src/variants/ccd-slice.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T17:32:45Z

libs/features/mas/web-components/src/variants/ccd-slice.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T17:32:46Z

libs/features/mas/web-components/src/variants/ccd-suggested.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

codecov · 2024-11-14T17:33:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (8b0c462) to head (6f4d98c).
Report is 85 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3200      +/-   ##
==========================================
- Coverage   96.37%   96.37%   -0.01%     
==========================================
  Files         245      245              
  Lines       56607    56716     +109     
==========================================
+ Hits        54557    54661     +104     
- Misses       2050     2055       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischrischris

* Add video embed regex * Use new api endpoin * Fix utils test; increase local timeout * Address @chrischrischris review

github-actions · 2024-11-14T20:12:36Z

libs/features/mas/web-components/src/variants/ccd-suggested.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T20:12:37Z

libs/features/mas/web-components/src/variants/variant-layout.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

hparra

Just a failing psi. Rerun?

saugatmalla and others added 5 commits November 14, 2024 17:29

[MWPW-161698] - Add two up in mobile for Editorial Card (#3170)

d19376d

add two up mobile variant

MWPW-156089: See what's included modal additional white space issue (#…

08fac6a

…3105) * added support for dynamic-height class * restricted width on large screens

[MWPW-140627] [MEP] Replace MEP placeholders when loading fragments (#…

0e407ec

…3193) Initial checkin. Replace Fragment placeholders.

milo-pr-merge bot requested a review from chrischrischris as a code owner November 14, 2024 17:30

github-actions bot reviewed Nov 14, 2024

View reviewed changes

mokimo temporarily deployed to milo_pr_merge November 14, 2024 20:11 — with GitHub Actions Inactive

MWPW-141870: Update seotech-video-url API endpoint (#3194)

6f4d98c

* Add video embed regex * Use new api endpoin * Fix utils test; increase local timeout * Address @chrischrischris review

milo-pr-merge bot requested a review from hparra as a code owner November 14, 2024 20:11

aem-code-sync bot temporarily deployed to stage November 14, 2024 20:11 Inactive

github-actions bot reviewed Nov 14, 2024

View reviewed changes

hparra approved these changes Nov 14, 2024

View reviewed changes

tedAir self-requested a review November 14, 2024 22:58

tedAir approved these changes Nov 14, 2024

View reviewed changes

mokimo temporarily deployed to milo_pr_merge November 26, 2024 04:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 26, 2024 08:15 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 26, 2024 09:17 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 26, 2024 12:21 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 26, 2024 16:14 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 26, 2024 20:12 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 27, 2024 00:55 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 27, 2024 04:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 27, 2024 08:15 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 27, 2024 09:17 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 27, 2024 12:21 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 27, 2024 16:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 27, 2024 20:12 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 28, 2024 00:54 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 28, 2024 04:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 28, 2024 08:14 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 28, 2024 09:17 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 28, 2024 12:21 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 28, 2024 16:12 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 28, 2024 20:11 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 29, 2024 00:54 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 29, 2024 04:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 29, 2024 08:14 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 29, 2024 09:17 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 29, 2024 12:20 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 29, 2024 16:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 29, 2024 20:11 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 30, 2024 00:52 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 30, 2024 04:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 30, 2024 08:13 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release] Stage to Main #3200

[Release] Stage to Main #3200

milo-pr-merge bot commented Nov 14, 2024 •

edited

Loading

milo-pr-merge bot commented Nov 14, 2024

aem-code-sync bot commented Nov 14, 2024 •

edited

Loading

aem-code-sync bot commented Nov 14, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

codecov bot commented Nov 14, 2024 •

edited

Loading

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

hparra left a comment

[Release] Stage to Main #3200

[Release] Stage to Main #3200

Conversation

milo-pr-merge bot commented Nov 14, 2024 • edited Loading

common base root URLs

milo-pr-merge bot commented Nov 14, 2024

aem-code-sync bot commented Nov 14, 2024 • edited Loading

aem-code-sync bot commented Nov 14, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

codecov bot commented Nov 14, 2024 • edited Loading

Codecov Report

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

hparra left a comment

Choose a reason for hiding this comment

milo-pr-merge bot commented Nov 14, 2024 •

edited

Loading

aem-code-sync bot commented Nov 14, 2024 •

edited

Loading

aem-code-sync bot commented Nov 14, 2024 •

edited

Loading

codecov bot commented Nov 14, 2024 •

edited

Loading