Fed Icons - Table icon decoration and collapse icon wrapping #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sartxi
requested review from
robert-bogos,
SilviuLCF,
rgclayton and
narcis-radu
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rparrish/fed-icons #3202 +/- ##
=====================================================
Coverage ? 96.38%
=====================================================
Files ? 245
Lines ? 56696
Branches ? 0
=====================================================
Hits ? 54646
Misses ? 2050
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sartxi
changed the title
overmyheadandbody
approved these changes
Nov 18, 2024
mokimo
approved these changes
Nov 18, 2024
ryanmparrish
approved these changes
Nov 21, 2024
mokimo
approved these changes
Nov 25, 2024
overmyheadandbody
pushed a commit
that referenced
this pull request
Dec 3, 2024
* reselect icons after area is decorated * fix inline margin issue in table collapse titles
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…idual SVG assets (#3259) * updated features/icons to pull from federal and allow the icons set to be sharepoint authorable * bettter icon-spacing handling * preload federated.js instead of non used icons.svg on util decorateIcon() * Updated preload federated as script type not fetch * Minor clean up based on pr feedback * remove console * addressed some issues found w/ icons not rending in tables due to race condition w/ decorateIcon() * lana instead of console * no 100% height * coverage * full coverage * minor cleanup * minor cleanup * preload first section icons, spread syntax * no cons * Performace refactor - loadIcons to hold most related functionallity. Preloaded inView icons and defered others till postSectionLoad. * async decTooltips and refactor to not chain func calls * fix: icon alignment in georouting modal's button * move render blocking code to utils * fix import of test method * remove condition that causes error when no icon is in view * remove redundant link load * remove extra federated.js import * small change to push branch * Fed Icons - Table icon decoration and collapse icon wrapping (#3202) * reselect icons after area is decorated * fix inline margin issue in table collapse titles --------- Co-authored-by: Saugat Malla <saugat@TBXTOR-2021MBP16-SaugatMalla.local> Co-authored-by: Saugat Malla <saugat013@gmail.com> Co-authored-by: Sartxi <sean.archibeque@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to the new federal icons work that was reverted, icons within tables were not having their respective SVG assets injected or tooltips being decorated. This was because the table block moves the icons around. I was able to see the icons being decorated by reselecting all icons before passing to icon js to be decorated and loaded.
There is also an issue where the expand/collapse icons wrapped to the bottom because of the new node index margin that was added. Unsetting that for this individual icon in the table.css.
Resolves: MWPW-140452
Test URLs:
URLs where issue was uncovered: