Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-162914 [nala][MEP]Nested placeholder issues #3244

Open
wants to merge 2 commits into
base: stage
Choose a base branch
from

Conversation

jpratt2
Copy link
Contributor

@jpratt2 jpratt2 commented Nov 22, 2024

This nala test addresses issues with nested placeholders: they should be accessible in a separate manifest and the most recent placeholder should replace the previous one.

Resolves: MWPW-162914

Test URLs:

Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://nested-placeholder--milo--adobecom.aem.page/?martech=off
PSI check: https://nested-placeholder--milo--adobecom.aem.page/?martech=off
test page with examples: https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/nested-placeholder/

Copy link
Contributor

aem-code-sync bot commented Nov 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Nov 22, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (82694a3) to head (b38a120).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3244   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         255      255           
  Lines       59363    59363           
=======================================
  Hits        57266    57266           
  Misses       2097     2097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Nov 30, 2024
@jpratt2
Copy link
Contributor Author

jpratt2 commented Dec 5, 2024

I am closing this PR because there is an outstanding issue: https://jira.corp.adobe.com/browse/MWPW-162760
When that MWPW ticket is closed, I will re-open a new PR

@jpratt2 jpratt2 closed this Dec 5, 2024
@jpratt2 jpratt2 reopened this Jan 7, 2025
@jpratt2
Copy link
Contributor Author

jpratt2 commented Jan 7, 2025

I need to re-open this pull request. I closed it incorrectly. I said that this outstanding issue was involved: "I am closing this PR because there is an outstanding issue: https://jira.corp.adobe.com/browse/MWPW-162760 "
It turns out that this issue is not related.
(It is only related to #2976)

@jpratt2
Copy link
Contributor Author

jpratt2 commented Jan 7, 2025

@skumar09 when you have a minute, for your review

@github-actions github-actions bot removed the Stale label Jan 7, 2025
@jpratt2 jpratt2 changed the title MWPW-162914 [nala][MEP]Nested placeholders MWPW-162914 [nala][MEP]Nested placeholder issues Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants