Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-162722: Sticky promo banner loading issue #3263

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

Copy link
Contributor

aem-code-sync bot commented Nov 26, 2024

Page Scores Audits Google
📱 /drafts/siva/162722/bf-promo-pepe-banner PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/siva/162722/bf-promo-pepe-banner PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (6f4d98c) to head (00feea1).
Report is 174 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3263      +/-   ##
==========================================
+ Coverage   96.37%   96.38%   +0.01%     
==========================================
  Files         245      245              
  Lines       56716    56735      +19     
==========================================
+ Hits        54661    54685      +24     
+ Misses       2055     2050       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, but I don't see a banner for the sticky top test page, could you add one for reference?

@sivasadobe
Copy link
Contributor Author

sivasadobe commented Dec 11, 2024

Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added Stale and removed Stale labels Dec 24, 2024
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jan 1, 2025
@spadmasa spadmasa removed the Stale label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@asonnalagi
Copy link

Verified the fix. Test results are in the task MWPW-164046

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 8, 2025
@milo-pr-merge milo-pr-merge bot merged commit 73cb4e7 into adobecom:stage Jan 9, 2025
25 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants