Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161937: Handles images during promote #3293

Merged
merged 1 commit into from
Dec 3, 2024
Merged

MWPW-161937: Handles images during promote #3293

merged 1 commit into from
Dec 3, 2024

Conversation

sukamat
Copy link
Contributor

@sukamat sukamat commented Dec 2, 2024

  • Retains image URL domain as-is for graybox during promote

Resolves: MWPW-161937

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Dec 2, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (floodbox@7e61a29). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tools/floodbox/search-replace.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             floodbox    #3293   +/-   ##
===========================================
  Coverage            ?   96.39%           
===========================================
  Files               ?      254           
  Lines               ?    57345           
  Branches            ?        0           
===========================================
  Hits                ?    55278           
  Misses              ?     2067           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sukamat sukamat merged commit 15dd8d6 into floodbox Dec 3, 2024
11 of 14 checks passed
@sukamat sukamat deleted the imagefix branch December 3, 2024 15:35
sukamat added a commit that referenced this pull request Jan 30, 2025
* Floodbox - Floodgate and Graybox app

* default path updated

* option to set promote ignore paths

* ignore files from promote

* Added tree crawler with graybox exp path support

* Intelligent org, repo, exp detection and validation

* Promote graybox at path and folder level

* Promote graybox files and folders with paths input

* UI updates to show crawl, promote and preview flow

* doc update

* Floodgate copy updates

* graybox refactor

* unit tests for utils

* lint fixes

* MWPW-161576: Path validation before GB promote (#3217)

* MWPW-161576: Path validation before GB promote

* Fixed lint issues

* unit tests added

* remove unused var

* graybox ui initial polish (#3223)

<!-- Before submitting, please review all open PRs. -->

* misc ui polishing

Resolves: [MWPW-161925](https://jira.corp.adobe.com/browse/MWPW-161925)

* Floodgate and Graybox app icons updated

* MWPW-161929: Central configuration support for Graybox on DA (#3231)

* Added Graybox Config support

* Post merge fixes

* refactor and made function private

* handles promote ignore on paths and folders

* added unit tests

* remove empty paths

* MWPW-161575: Floodgate app on DA - initial draft (#3240)

* floodgate promote first draft

* lint fix

* fixed quotes

* MWPW-161911: DA FG App Configuration (#3249)

* Floodgate config to drive promote rules

* unit tests added

* temp change revert

* Handles promote on drafts path only (#3262)

Handle promote on drafts path only

* DA Graybox UI (#3266)

* DA Graybox UI
<!-- Before submitting, please review all open PRs. -->

* Tab UI for each step to promote
* Detail cards for each step
* Cleaned up the existing UI buttons and options

Resolves: [MWPW-161925](https://jira.corp.adobe.com/browse/MWPW-161925)

* removed placeholder paths

* MWPW-161576: DA Floodbox UTs (#3291)

* Unit tests for DA Floodbox

* request handler changes

* refactor updates

* eslint fixes

* eslint fixes

* MWPW-161937: Handles images during promote (#3293)

* MWPW-163511: DA Floodgate Copy Action (#3298)

* MWPW-163511: DA Floodgate Copy

* Updated unit tests

* MWPW-161575: Unit tests for FG and GB (#3307)

* MWPW-161575: Fragments and Asset extraction (#3316)

- Limited to /fragments/ path and to pdf, svg and json references only

* MWPW-163865: Ribbon UI for DA Graybox (#3340)

* MWPW-163865: Ribbon UI for DA Graybox

* eslint fix

* DA graybox UI finalized (#3342)

DA Graybox UI - Finalized
<!-- Before submitting, please review all open PRs. -->

* URL lists for ignore and errors
* App reset when done
* Refactor for reuse in floodgate

Resolves: [MWPW-163768](https://jira.corp.adobe.com/browse/MWPW-163768)

* DA Graybox UI Bug Fixes (#3352)

<!-- Before submitting, please review all open PRs. -->

* fix for reset tokens
* fix for promote count with errors

Resolves: [MWPW-164020](https://jira.corp.adobe.com/browse/MWPW-164020)

Resolves: [MWPW-163995](https://jira.corp.adobe.com/browse/MWPW-163995)

* MWPW-161575: Path validation fix (#3373)

* MWPW-161575: Path validation fix

* markup update

* DA Floodgate Promote UI (#3378)

<!-- Before submitting, please review all open PRs. -->

* UI for the promote option

Resolves: [MWPW-161908](https://jira.corp.adobe.com/browse/MWPW-161908)

* DA Floodgate Copy UI (#3395)

* DA Floodgate Copy UI
<!-- Before submitting, please review all open PRs. -->

* UI for the copy option

Resolves: [MWPW-161908](https://jira.corp.adobe.com/browse/MWPW-161908)

* fix for copy error list color

* pr feedback

* more pr feedback about fragments and assets

* MWPW-164330: Delete Option in DA FG App (#3399)

* MWPW-164330: Delete Option in DA FG

* reset repo ready flag

* repo data move

* confirmation dialog

* minor change

* error card css update

* renders error list for unpublish and delete

* MWPW-161575: Unit tests added for DA FB (#3405)

* bulk action unit tests

* promote class unit tests

* fg utils unit tests updated

* MWPW-161920: Authenticated site support for preview (#3446)

* MWPW-161920: Authenticated site support for preview

- For preview/publish Helix API call, the auth token is passed in as the site is behind auth
- mp4 reference check added

* removed mp4 check

* Removing the apps from config.json

This needs to be added in the consumer DA repos when needed. Removing it from Milo repo to avoid conflicts.

---------

Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants