Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENB-7566] Change domain names for stage, remove personalization logic for not signed in #3324

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

@swamu swamu requested a review from sharg1 December 6, 2024 08:53
Copy link
Contributor

aem-code-sync bot commented Dec 6, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@swamu swamu requested a review from amitbikram December 6, 2024 08:53
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.42%. Comparing base (b72ed94) to head (8203ead).
Report is 10 commits behind head on stage.

Files with missing lines Patch % Lines
libs/martech/helpers.js 95.12% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            stage    #3324    +/-   ##
========================================
  Coverage   96.41%   96.42%            
========================================
  Files         246      246            
  Lines       57567    57694   +127     
========================================
+ Hits        55504    55629   +125     
- Misses       2063     2065     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swamu swamu requested review from mokimo and bbythewa December 6, 2024 08:55
@swamu swamu added needs-verification PR requires E2E testing by a reviewer high priority Why is this a high priority? Blocker? Critical? Dependency? labels Dec 6, 2024
libs/martech/helpers.js Outdated Show resolved Hide resolved
@sharg1 sharg1 removed the high priority Why is this a high priority? Blocker? Critical? Dependency? label Dec 6, 2024
@swamu swamu requested review from mokimo and pooja-mittal December 6, 2024 09:37
@sharg1
Copy link
Contributor

sharg1 commented Dec 6, 2024

From our internal discussions, this seems to be high priority to go live by 10th dec. @swamu feel free to add the label back once approvals + verifications are in place.

@Nadeemakramn Nadeemakramn added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Dec 6, 2024
@Nadeemakramn
Copy link

Changes Approved.

@swamu swamu added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@swamu swamu force-pushed the ENB-7556-update-api-endpoints branch from 58efa9e to 2e0bd5a Compare December 9, 2024 10:21
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 9, 2024

Skipped 3324: "[ENB-7566] Change domain names for stage, remove personalization logic for not signed in" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small improvement idea

libs/martech/helpers.js Show resolved Hide resolved
@milo-pr-merge milo-pr-merge bot merged commit cdd773a into adobecom:stage Dec 10, 2024
19 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 10, 2024
nishantka pushed a commit to nishantka/milo that referenced this pull request Dec 13, 2024
…c for not signed in (adobecom#3324)

* remobe personalization for signed out, change domain names for stage and prod

* dummy-pr

* remove hlx and aem check for getting url

* A&T property check on default production

* Fix decode URI at the base

* Fix amcv cookie name post decode

* Add Amcv encoding during setting cookie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants