-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENB-7566] Change domain names for stage, remove personalization logic for not signed in #3324
[ENB-7566] Change domain names for stage, remove personalization logic for not signed in #3324
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #3324 +/- ##
========================================
Coverage 96.41% 96.42%
========================================
Files 246 246
Lines 57567 57694 +127
========================================
+ Hits 55504 55629 +125
- Misses 2063 2065 +2 ☔ View full report in Codecov by Sentry. |
From our internal discussions, this seems to be high priority to go live by 10th dec. @swamu feel free to add the label back once approvals + verifications are in place. |
Changes Approved. |
Reminder to set the |
58efa9e
to
2e0bd5a
Compare
Skipped 3324: "[ENB-7566] Change domain names for stage, remove personalization logic for not signed in" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small improvement idea
…c for not signed in (adobecom#3324) * remobe personalization for signed out, change domain names for stage and prod * dummy-pr * remove hlx and aem check for getting url * A&T property check on default production * Fix decode URI at the base * Fix amcv cookie name post decode * Add Amcv encoding during setting cookie
Bug 1:
prod: https://www.adobe.com/experienceedge/ee/v2/interact (based on domain name)
stage: https://www.stage.adobe.com/experienceedge/ee/v2/interact
dev/hlx: https://edge.adobedc.net/ee/v2/interact
Bug 2:
Fix campaign applying without target=on ( when personalization is present)
https://main--cc--adobecom.hlx.live/drafts/suhjain/swati-pages/photoshop-v2?target=on&milolibs=ENB-7556-update-api-endpoints--milo--swamu#
Resolves: ENB-7556
Test URLs:
Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://ENB-7556-update-api-endpoints--milo--swamu.aem.page/?martech=off