Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helpx and stock url to prodDomains for standalone gnav #3333

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Copy link
Contributor

aem-code-sync bot commented Dec 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Dec 9, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (39eafc8) to head (b644785).
Report is 3 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3333   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         246      246           
  Lines       57676    57683    +7     
=======================================
+ Hits        55613    55620    +7     
  Misses       2063     2063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa
Copy link

spadmasa commented Dec 9, 2024

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Dec 9, 2024
@bandana147 bandana147 added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Dec 9, 2024
@bandana147
Copy link
Contributor Author

Adding high priority as this is a blocker for adobe home ROW release

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 9, 2024

Skipped merging 3333: Adding helpx and stock url to prodDomains for standalone gnav due to failing checks

@milo-pr-merge milo-pr-merge bot merged commit 57c5490 into stage Dec 10, 2024
14 checks passed
@milo-pr-merge milo-pr-merge bot deleted the gnav-prodDomains branch December 10, 2024 09:18
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants