Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENB-7567] Remove ee from the link #3347

Merged

Conversation

swamu
Copy link
Contributor

@swamu swamu commented Dec 10, 2024

Copy link
Contributor

aem-code-sync bot commented Dec 10, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (00c690b) to head (9a8a98f).
Report is 1 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3347   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files         253      253           
  Lines       58761    58761           
=======================================
  Hits        56669    56669           
  Misses       2092     2092           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swamu swamu force-pushed the enb-7567-fix-sporadic-failing-link branch from f1632de to 2411fc2 Compare December 10, 2024 10:23
@swamu swamu changed the title Remove ee from the link [ENB-7567] Remove ee from the link Dec 10, 2024
@swamu swamu requested review from amitbikram and Bhim12 December 10, 2024 10:39
@swamu swamu added the needs-verification PR requires E2E testing by a reviewer label Dec 10, 2024
@Nadeemakramn Nadeemakramn added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Dec 10, 2024
@swamu swamu requested a review from Nadeemakramn December 10, 2024 11:21
@swamu swamu added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Dec 10, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 10, 2024

Skipped merging 3347: [ENB-7567] Remove ee from the link due to failing checks

@milo-pr-merge milo-pr-merge bot merged commit 6c756bc into adobecom:stage Dec 10, 2024
14 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 10, 2024
nishantka pushed a commit to nishantka/milo that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants