generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENB-7567] Remove ee from the link #3347
Merged
milo-pr-merge
merged 2 commits into
adobecom:stage
from
swamu:enb-7567-fix-sporadic-failing-link
Dec 10, 2024
Merged
[ENB-7567] Remove ee from the link #3347
milo-pr-merge
merged 2 commits into
adobecom:stage
from
swamu:enb-7567-fix-sporadic-failing-link
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3347 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 253 253
Lines 58761 58761
=======================================
Hits 56669 56669
Misses 2092 2092 ☔ View full report in Codecov by Sentry. |
swamu
force-pushed
the
enb-7567-fix-sporadic-failing-link
branch
from
December 10, 2024 10:23
f1632de
to
2411fc2
Compare
mokimo
approved these changes
Dec 10, 2024
Bhim12
approved these changes
Dec 10, 2024
Nadeemakramn
added
verified
PR has been E2E tested by a reviewer
Ready for Stage
and removed
needs-verification
PR requires E2E testing by a reviewer
labels
Dec 10, 2024
swamu
added
the
high priority
Why is this a high priority? Blocker? Critical? Dependency?
label
Dec 10, 2024
Skipped merging 3347: [ENB-7567] Remove ee from the link due to failing checks |
amitbikram
approved these changes
Dec 10, 2024
nishantka
pushed a commit
to nishantka/milo
that referenced
this pull request
Dec 13, 2024
Remove ee from the link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
high priority
Why is this a high priority? Blocker? Critical? Dependency?
Ready for Stage
verified
PR has been E2E tested by a reviewer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
ee
from url sporadic behaviour or API failingENB-7567
Test URLs:
Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://enb-7567-fix-sporadic-failing-link--milo--swamu.aem.page/?martech=off