-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-162795: Complimentary/Product Entry CTAs #3354
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3354 +/- ##
=======================================
Coverage 96.46% 96.47%
=======================================
Files 255 255
Lines 59255 59265 +10
=======================================
+ Hits 57160 57175 +15
+ Misses 2095 2090 -5 ☔ View full report in Codecov by Sentry. |
Reminder to set the |
8cd6e31
to
2b5630d
Compare
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Skipped 3354: "MWPW-162795: Complimentary/Product Entry CTAs" due to file "libs/blocks/global-navigation/global-navigation.js" overlap. Merging will be attempted in the next batch |
Added functionality for Complimentary Web App Sign-in CTA, allowing authors to selectively enable or disable it on specific pages under a given Local Nav.
Resolves: MWPW-162795
Test URLs:
QA: https://main--cc--adobecom.hlx.page/drafts/akansha/features?milolibs=MWPW-162795--milo--akanshaa-18