Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-162795: Complimentary/Product Entry CTAs #3354

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

akanshaa-18
Copy link
Contributor

Added functionality for Complimentary Web App Sign-in CTA, allowing authors to selectively enable or disable it on specific pages under a given Local Nav.

Resolves: MWPW-162795

Test URLs:

QA: https://main--cc--adobecom.hlx.page/drafts/akansha/features?milolibs=MWPW-162795--milo--akanshaa-18

Copy link
Contributor

aem-code-sync bot commented Dec 11, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (c36fb32) to head (433f112).
Report is 13 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3354   +/-   ##
=======================================
  Coverage   96.46%   96.47%           
=======================================
  Files         255      255           
  Lines       59255    59265   +10     
=======================================
+ Hits        57160    57175   +15     
+ Misses       2095     2090    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa spadmasa self-assigned this Dec 11, 2024
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@akanshaa-18 akanshaa-18 force-pushed the MWPW-162795 branch 2 times, most recently from 8cd6e31 to 2b5630d Compare December 12, 2024 06:29
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added Stale and removed Stale labels Dec 20, 2024
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Dec 29, 2024
@akanshaa-18 akanshaa-18 changed the title MWPW-162795: Complimentary Web App Sign In MWPW-162795: Complimentary/Product Entry CTAs Jan 2, 2025
@spadmasa spadmasa removed the Stale label Jan 2, 2025
@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 3, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 7, 2025

Skipped 3354: "MWPW-162795: Complimentary/Product Entry CTAs" due to file "libs/blocks/global-navigation/global-navigation.js" overlap. Merging will be attempted in the next batch

@spadmasa spadmasa added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Jan 8, 2025
@milo-pr-merge milo-pr-merge bot merged commit faf70c2 into adobecom:stage Jan 9, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants