MWPW-164094 Fix algorithm for calculation of PUF optical #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3370 +/- ##
==========================================
- Coverage 96.46% 96.46% -0.01%
==========================================
Files 255 255
Lines 59363 59352 -11
==========================================
- Hits 57266 57252 -14
- Misses 2097 2100 +3 ☔ View full report in Codecov by Sentry. |
added 2 commits
December 12, 2024 13:51
mirafedas
requested changes
Dec 18, 2024
3ch023
approved these changes
Dec 19, 2024
mirafedas
approved these changes
Dec 23, 2024
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
|
Skipped 3370: "MWPW-164094 Fix algorithm for calculation of PUF optical" due to file "libs/deps/mas/mas.js" overlap. Merging will be attempted in the next batch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUF optical price calculation algorithm needs to be improved to match the prices on commerce page.
Test pages :
/drafts/bozo/pufoptical
/in/drafts/mariia/optical/in
Resolves: MWPW-164094
Test URLs: