-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-160811 [coll] allow search & results & total digit token with / #3385
Conversation
- allow /search/ and /results/ token that are easy to set in 'do not translate' mode, - add unit test - add additional safeguard to slot text retrieval,
|
Reminder to set the |
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
@npeltier Plz pull latest files from stage - in your branch |
this is done @Roycethan |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3385 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 255 255
Lines 59363 59365 +2
=======================================
+ Hits 57266 57268 +2
Misses 2097 2097 ☔ View full report in Codecov by Sentry. |
@npeltier Looks like theres conflicts due to last merge, can you plz resolve them, once done i'll add label |
you can test the other configuration in /drafts/npeltier/catalog?milolibs=mwpw-160811--milo--npeltier, old one should still be working (backward compatibility)
Test URLs: