Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-160811 [coll] allow search & results & total digit token with / #3385

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

npeltier
Copy link
Contributor

  • allow /search/ and /results/ token that are easy to set in 'do not translate' mode,
  • add unit test
  • add additional safeguard to slot text retrieval,

you can test the other configuration in /drafts/npeltier/catalog?milolibs=mwpw-160811--milo--npeltier, old one should still be working (backward compatibility)

Test URLs:

- allow /search/ and /results/ token that are easy to set in 'do not translate' mode,
- add unit test
- add additional safeguard to slot text retrieval,
@npeltier npeltier requested a review from a team as a code owner December 16, 2024 21:52
Copy link
Contributor

aem-code-sync bot commented Dec 16, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Dec 27, 2024
@github-actions github-actions bot removed the Stale label Dec 31, 2024
@Roycethan
Copy link

@npeltier Plz pull latest files from stage - in your branch
observed an old regression caused by one of PR on stage which was reverted some time back
https://main--homepage--adobecom.hlx.live/homepage/index-loggedout?milolibs=mwpw-160811--milo--npeltier
image

@npeltier
Copy link
Contributor Author

npeltier commented Jan 7, 2025

this is done @Roycethan

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (82694a3) to head (4e10c0a).
Report is 8 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3385   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         255      255           
  Lines       59363    59365    +2     
=======================================
+ Hits        57266    57268    +2     
  Misses       2097     2097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Roycethan
Copy link

this is done @Roycethan

@npeltier Looks like theres conflicts due to last merge, can you plz resolve them, once done i'll add label

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 7, 2025
@milo-pr-merge milo-pr-merge bot merged commit 56b944a into adobecom:stage Jan 9, 2025
24 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants