Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-161858] Remove sticky section when footer is visible #3402

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[MWPW-161858] Remove sticky section when footer is visible #3402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libs/blocks/section-metadata/sticky-section.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ function handleTopHeight(section) {
section.style.top = `${headerHeight}px`;
}

let isFooterStart = false;
robert-bogos marked this conversation as resolved.
Show resolved Hide resolved
function promoIntersectObserve(el, stickySectionEl, options = {}) {
const io = new IntersectionObserver((entries, observer) => {
entries.forEach((entry) => {
Expand All @@ -17,7 +18,8 @@ function promoIntersectObserve(el, stickySectionEl, options = {}) {
const isPromoStart = entry.target === stickySectionEl;
const abovePromoStart = (isPromoStart && entry.isIntersecting)
|| stickySectionEl?.getBoundingClientRect().y > 0;
if (entry.isIntersecting || abovePromoStart) el.classList.add('hide-sticky-section');
if (entry.target === document.querySelector('footer')) isFooterStart = entry.isIntersecting;
robert-bogos marked this conversation as resolved.
Show resolved Hide resolved
if (entry.isIntersecting || abovePromoStart || isFooterStart) el.classList.add('hide-sticky-section');
else el.classList.remove('hide-sticky-section');
});
}, options);
Expand Down
Loading