Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for georouting popup link is seen rendered out of the popup in mobile portrait view in arabic locale #3406

Closed
wants to merge 2 commits into from
Closed

fix for georouting popup link is seen rendered out of the popup in mobile portrait view in arabic locale #3406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2243078
fix for georouting popup link is seen rendered out of the popup in mo…
patel-prince Dec 23, 2024
a05d5c7
undo changes
patel-prince Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/features/georoutingv2/georoutingv2.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
}

.dialog-modal.locale-modal-v2 a:last-child {
white-space: nowrap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vhargrave may have more insight on this, but I'd assume that this declaration was intentional. I had a look on mena_ar and the suggested change would make it look like:

Although without this change it looks like:

I'd also question the device used to surface this issue. I had to go down to 280px width to replicate the bug, although it's not a common occurrence according to this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bug has been raised based on this url, https://www.adobe.com/mena_ar/products/photoshop.html
image-2024-12-17-13-28-30-031
as per the bug this issue is happening below 375px screen size.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just looking at this now. @overmyheadandbody yeah, I originally added that css so that the United States text wouldn't wrap like it was doing here, and I wasn't accounting for screens below 300px:

image

The display: inline-block also seems to prevent that wrapping though and solves this other , if quite rare, bug.
So I think since it's not making things worse and solving this issue, this is probably fine to get added. 👍

white-space: no-wrap;
}

.dialog-modal.locale-modal-v2 .picker li {
Expand Down
Loading