language based region nav config

[vhargrave]

Resolves: MWPW-164320

Adds support to the region nav for sites that are language-based.
Based on this github discussion. - https://github.com/orgs/adobecom/discussions/3383

Test URLs:

• Before: https://main--milo--adobecom.aem.page/?martech=off
• After: https://vhargrave-language-based-region-nav-config--milo--adobecom.aem.page/?martech=off

Express (with language map). (Notice how the Portuguese link changes to /br or the Mexican one to /es)

• Before: https://vhargrave-region-nav--express-milo--adobecom.hlx.page/in/express/?martech=off
• After: https://vhargrave-region-nav--express-milo--adobecom.hlx.page/in/express/?martech=off&milolibs=vhargrave-language-based-region-nav-config#langnav

Express (with language map on a sub page that does have localized versions of the page)

• Before: https://vhargrave-region-nav--express-milo--adobecom.hlx.page/in/express/business?martech=off
• After: https://vhargrave-region-nav--express-milo--adobecom.hlx.page/in/express/business?martech=off&milolibs=vhargrave-language-based-region-nav-config#langnav

Express (with language map on a blog page that doesn't have localized version of the page)

• Before: https://vhargrave-region-nav--express-milo--adobecom.hlx.page/express/learn/blog/desktop-announcement?martech=off#langnav
• After: https://vhargrave-region-nav--express-milo--adobecom.hlx.page/express/learn/blog/desktop-announcement?martech=off&milolibs=vhargrave-language-based-region-nav-config#langnav

CC (no changes since this is opt-in and cc has no language map)

• Before: https://main--cc--adobecom.hlx.page/products/photoshop-lightroom?martech=off#langnav
• After: https://main--cc--adobecom.hlx.page/products/photoshop-lightroom?martech=off&milolibs=vhargrave-language-based-region-nav-config#langnav

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 485b443 ✅ (latest)
• 7572f0f ✅
• 61b964a ✅
• 09032c2 ✅
• 042ced5 ✅
• 1a76556 ✅
• 19e8fee ❌

[aem-code-sync]

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.45%. Comparing base (82694a3) to head (485b443).
Report is 10 commits behind head on stage.

Files with missing lines	Patch %	Lines
libs/blocks/region-nav/region-nav.js	75.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #3425      +/-   ##
==========================================
- Coverage   96.46%   96.45%   -0.01%     
==========================================
  Files         255      255              
  Lines       59363    59378      +15     
==========================================
+ Hits        57266    57276      +10     
- Misses       2097     2102       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mokimo]

Seems like the nala tests fail can you try

1. to purge the code of ur branch? - example purge request: CURL -si -X POST https://admin.hlx.page/code/mokimo/milo/thebranchimworkingon/* and re-run the nala tests
2. if that doesn't work, to rebase to stage & then push ur branch?

[github-actions]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

[vhargrave]

Seems like the nala tests fail can you try

1. to purge the code of ur branch? - example purge request: CURL -si -X POST https://admin.hlx.page/code/mokimo/milo/thebranchimworkingon/* and re-run the nala tests
2. if that doesn't work, to rebase to stage & then push ur branch?

@mokimo did that, but now the nala tests started getting skipped even though I didn't configure that. They're getting skipped for other PRs too. It's a little strange.

[mokimo]

@vhargrave there's two nala suites running
https://github.com/adobecom/milo/actions/runs/12655761620/workflow?pr=3425 & https://github.com/adobecom/milo/actions/runs/12655761629/workflow?pr=3425

The skipped test conditionally runs on consumers if: contains(join(github.event.pull_request.labels.*.name, ' '), 'run-nala-on-') based on adding a label. Or at least thats what it seems like to me looking at the WF files.

Here's how you can quickly connect a check to it's workflow file

1. Go into the check details
   
2. Check how the action is even triggered
   

[vhargrave]

@vhargrave there's two nala suites running https://github.com/adobecom/milo/actions/runs/12655761620/workflow?pr=3425 & https://github.com/adobecom/milo/actions/runs/12655761629/workflow?pr=3425

The skipped test conditionally runs on consumers if: contains(join(github.event.pull_request.labels.*.name, ' '), 'run-nala-on-') based on adding a label. Or at least thats what it seems like to me looking at the WF files.

Here's how you can quickly connect a check to it's workflow file

1. Go into the check details
   
2. Check how the action is even triggered
   

@mokimo Ah I see , thanks 👍. And I can see the other suite is running which is what we wanted 👍

[mokimo]

Cool 🚀

[milo-pr-merge]

Skipped merging 3425: language based region nav config due to failing checks