Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOC] MWPW-164734 - single rollout for loc #3428

Conversation

saurabhsircar11
Copy link
Contributor

@saurabhsircar11 saurabhsircar11 commented Jan 7, 2025

Copy link
Contributor

aem-code-sync bot commented Jan 7, 2025

Page Scores Audits Google
📱 /drafts/sircar/locui-create?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/sircar/locui-create?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@saurabhsircar11 saurabhsircar11 added trivial PR doesn't require E2E testing by a reviewer zero-impact labels Jan 7, 2025
Copy link
Contributor

@JasonHowellSlavin JasonHowellSlavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits, looks good to me.

libs/blocks/locui-create/input-locale/index.js Outdated Show resolved Hide resolved
libs/blocks/locui-create/locui-create.css Outdated Show resolved Hide resolved
Copy link
Contributor

@nkthakur48 nkthakur48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhsircar11 please have a look at the suggestion

libs/blocks/locui-create/input-locale/index.js Outdated Show resolved Hide resolved
@nkthakur48 nkthakur48 merged commit be6fe90 into adobecom:milostudio-stage Jan 9, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial PR doesn't require E2E testing by a reviewer zero-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants