generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LOC] MWPW-164734 - single rollout for loc #3428
Merged
nkthakur48
merged 4 commits into
adobecom:milostudio-stage
from
saurabhsircar11:MWPW-164734-single-rollout
Jan 9, 2025
Merged
[LOC] MWPW-164734 - single rollout for loc #3428
nkthakur48
merged 4 commits into
adobecom:milostudio-stage
from
saurabhsircar11:MWPW-164734-single-rollout
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added single url rollout flow Resolves: https://jira.corp.adobe.com/browse/MWPW-164734 **Test URLs:** - Before: https://stage--milo--adobecom.hlx.page/drafts/sircar/locui-create?martech=off - After: https://MWPW-164734-single-rollout--milo--saurabhsircar11.hlx.page/drafts/sircar/locui-create?martech=off
* set initByParams to null Resolves: https://jira.corp.adobe.com/browse/MWPW-164734 **Test URLs:** - Before: https://stage--milo--adobecom.hlx.page/drafts/sircar/locui-create?martech=off - After: https://MWPW-164734-single-rollout--milo--saurabhsircar11.hlx.page/drafts/sircar/locui-create?martech=off
|
saurabhsircar11
added
trivial
PR doesn't require E2E testing by a reviewer
zero-impact
labels
Jan 7, 2025
hnvadobe
approved these changes
Jan 8, 2025
JasonHowellSlavin
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nits, looks good to me.
* fixed code review comments. Resolves: https://jira.corp.adobe.com/browse/MWPW-164734 **Test URLs:** - Before: https://stage--milo--adobecom.hlx.page/drafts/sircar/locui-create?martech=off - After: https://MWPW-164734-single-rollout--milo--saurabhsircar11.hlx.page/drafts/sircar/locui-create?martech=off
nkthakur48
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saurabhsircar11 please have a look at the suggestion
* fixed code review comments. Resolves: https://jira.corp.adobe.com/browse/MWPW-164734 **Test URLs:** - Before: https://stage--milo--adobecom.hlx.page/drafts/sircar/locui-create?martech=off - After: https://MWPW-164734-single-rollout--milo--saurabhsircar11.hlx.page/drafts/sircar/locui-create?martech=off
nkthakur48
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://jira.corp.adobe.com/browse/MWPW-164734
Test URLs: