Tooltip icon to be tabbed and showing the tooltip #3431
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3431 +/- ##
==========================================
- Coverage 96.47% 96.46% -0.01%
==========================================
Files 255 255
Lines 59253 59364 +111
==========================================
+ Hits 57163 57267 +104
- Misses 2090 2097 +7 ☔ View full report in Codecov by Sentry. |
| @@ -46,6 +46,7 @@ function decorateToolTip(icon) { | |||
| // Position is the next to last part of a tooltip | |||
| const place = conf.pop()?.trim().toLowerCase() || 'right'; | |||
| icon.className = `icon icon-info milo-tooltip ${place}`; | |||
| icon.setAttribute('tabindex', '0'); | |||
There was a problem hiding this comment.
This is under decorateToolTip() which means my code affects only for tooltip.
There was a problem hiding this comment.
@seanchoi-dev
Although now info icon is foccussed using keyboard, its not operable using Enter/Spacebar, one of the other requirement #2 is to Open and Close the tooltip info by using Enter/Spacebar
ex:https://main--dc--adobecom.hlx.live/acrobat/pricing?martech=off&milolibs=MWPW-162384
Note : Similar one is fixed by Bozo for Titan Plans modal in this ticket : https://jira.corp.adobe.com/browse/MWPW-163873
Resolves: MWPW-162384
Test URLs:
Test for consumer URLs: