Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Gnav Standalone Localnav curtain was missing some styles #3435

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

sharmrj
Copy link
Contributor

@sharmrj sharmrj commented Jan 8, 2025

Copy link
Contributor

aem-code-sync bot commented Jan 8, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@sharmrj sharmrj changed the base branch from stage to mobile-gnav January 8, 2025 12:54
Copy link
Contributor

aem-code-sync bot commented Jan 8, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (490a349) to head (c1f8bad).
Report is 2 commits behind head on mobile-gnav.

Additional details and impacted files
@@               Coverage Diff               @@
##           mobile-gnav    #3435      +/-   ##
===============================================
- Coverage        98.53%   96.48%   -2.05%     
===============================================
  Files               77      256     +179     
  Lines             9882    59915   +50033     
===============================================
+ Hits              9737    57811   +48074     
- Misses             145     2104    +1959     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bandana147 bandana147 merged commit 9a9d426 into mobile-gnav Jan 8, 2025
11 of 12 checks passed
@bandana147 bandana147 deleted the mobile-gnav-standalone branch January 8, 2025 13:05
bandana147 pushed a commit that referenced this pull request Jan 9, 2025
* Added styles necessary for the standalone localnav to function

* missed a css variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants