Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-160808: fassform is seen displayed without the #id and not able to close #3471

Open
wants to merge 2 commits into
base: stage
Choose a base branch
from

Conversation

Copy link
Contributor

aem-code-sync bot commented Jan 13, 2025

Page Scores Audits Google
📱 /docs/authoring/create-modal PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /docs/authoring/create-modal PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (6eb0401) to head (126e834).
Report is 30 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3471      +/-   ##
==========================================
- Coverage   96.47%   96.46%   -0.02%     
==========================================
  Files         258      258              
  Lines       60150    60150              
==========================================
- Hits        58029    58022       -7     
- Misses       2121     2128       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpratt2
Copy link
Contributor

jpratt2 commented Jan 13, 2025

@sivasadobe
Regarding the failed nala tests, could you give this a try: pull the recent changes from stage into your branch and then re-push your branch
cc: @skumar09

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants