Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-164735 - States/Properties: The element has missing or incorrect states or properties - Change Region #3486

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

sonawanesnehal3
Copy link
Contributor

Accessibility bug - States/Properties: The element has missing or incorrect states or properties - Change Region

Resolves: MWPW-164735

Test URLs:

@sonawanesnehal3 sonawanesnehal3 added the needs-verification PR requires E2E testing by a reviewer label Jan 15, 2025
Copy link
Contributor

aem-code-sync bot commented Jan 15, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 15, 2025

Page Scores Audits Google
📱 /drafts/snehal/illustrator?marchtech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/snehal/illustrator?marchtech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (6eb0401) to head (135c937).
Report is 6 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3486      +/-   ##
==========================================
- Coverage   96.47%   96.46%   -0.01%     
==========================================
  Files         258      258              
  Lines       60150    60149       -1     
==========================================
- Hits        58029    58023       -6     
- Misses       2121     2126       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonawanesnehal3 sonawanesnehal3 changed the title States/Properties: The element has missing or incorrect states or properties - Change Region MWPW-164735 - States/Properties: The element has missing or incorrect states or properties - Change Region Jan 15, 2025
@bandana147
Copy link
Contributor

@sonawanesnehal3 You have made sure it is not impacting the drop up change region?

Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@sonawanesnehal3
Copy link
Contributor Author

@sonawanesnehal3 You have made sure it is not impacting the drop up change region?

Thanks @bandana147.
Done. Please review.

@prativas22
Copy link

@prativas22 prativas22 added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Jan 20, 2025
@milo-pr-merge milo-pr-merge bot merged commit c88d80c into stage Jan 20, 2025
25 checks passed
@milo-pr-merge milo-pr-merge bot deleted the mwpw-164735 branch January 20, 2025 16:17
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants