Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Release] Stage to Main" #3496

Closed
wants to merge 1 commit into from
Closed

Conversation

salonijain3
Copy link
Contributor

Reverts #3487

Copy link
Contributor

aem-code-sync bot commented Jan 16, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

await sendKeys({ press: 'ArrowRight' });
expect(document.activeElement).to.equal(element);
}
if (!isElementVisible(element)) continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-continue> reported by reviewdog 🐶
Unexpected use of continue statement.

await sendKeys({ press: 'ArrowLeft' });
expect(document.activeElement).to.equal(element);
}
if (!isElementVisible(element)) continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-continue> reported by reviewdog 🐶
Unexpected use of continue statement.

await sendKeys({ press: 'ArrowUp' });
expect(document.activeElement).to.equal(element);
}
if (!isElementVisible(element)) continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-continue> reported by reviewdog 🐶
Unexpected use of continue statement.

await sendKeys({ press: 'ArrowDown' });
expect(document.activeElement).to.equal(element);
}
if (!isElementVisible(element)) continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-continue> reported by reviewdog 🐶
Unexpected use of continue statement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 96.37681% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.45%. Comparing base (409ed68) to head (9fd4688).

Files with missing lines Patch % Lines
...ocks/global-navigation/utilities/keyboard/index.js 70.00% 3 Missing ⚠️
...lobal-navigation/utilities/keyboard/mobilePopup.js 91.66% 1 Missing ⚠️
libs/blocks/merch-card/merch-card.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3496      +/-   ##
==========================================
- Coverage   96.47%   96.45%   -0.03%     
==========================================
  Files         256      255       -1     
  Lines       60101    59430     -671     
==========================================
- Hits        57984    57324     -660     
+ Misses       2117     2106      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants