Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-165782] - Hamburger icon issue fix #3501

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Conversation

Deva309
Copy link
Contributor

@Deva309 Deva309 commented Jan 16, 2025

  1. Fix for close icon which is seen replaced with hamburger after the new mobile GNAV code changes
  2. Fix for GNAV height issue in case of app banner is present on the page.
  3. Made the header sticky in mobile with newNav disabled

Resolves: MWPW-165782

Test URLs:

QA:
https://main--cc--adobecom.hlx.page/products/photoshop?newNav=false (before fix)
https://main--cc--adobecom.hlx.page/products/photoshop?newNav=false&milolibs=mwpw-165782--milo--deva309 (After fix)

https://main--cc--adobecom.hlx.page/products/photoshop-lightroom?milolibs=mwpw-165782--milo--deva309 (app banner issue fix)
https://main--federal--adobecom.hlx.page/federal/dev/blaishram/page-with-promo?milolibs=mwpw-165782--milo--deva309 (stickyheader with newNav disabled)

Copy link
Contributor

aem-code-sync bot commented Jan 16, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (6eb0401) to head (328d1f1).
Report is 4 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3501   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         258      258           
  Lines       60150    60151    +1     
=======================================
+ Hits        58029    58033    +4     
+ Misses       2121     2118    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Deva309 Deva309 added the needs-verification PR requires E2E testing by a reviewer label Jan 16, 2025
@spadmasa spadmasa self-assigned this Jan 16, 2025
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@prativas22 prativas22 added verified PR has been E2E tested by a reviewer Ready for Stage high priority Why is this a high priority? Blocker? Critical? Dependency? and removed needs-verification PR requires E2E testing by a reviewer labels Jan 20, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 20, 2025

Skipped merging 3501: [MWPW-165782] - Hamburger icon issue fix due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 20, 2025

Skipped 3501: "[MWPW-165782] - Hamburger icon issue fix" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

@mokimo mokimo merged commit c1dd016 into adobecom:stage Jan 20, 2025
14 checks passed
@mokimo mokimo mentioned this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants