-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-165782] - Hamburger icon issue fix #3501
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3501 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 258 258
Lines 60150 60151 +1
=======================================
+ Hits 58029 58033 +4
+ Misses 2121 2118 -3 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Verified the fixes for the issues below; the result looks good. CC: https://main--cc--adobecom.hlx.page/drafts/prativa/Promobar/aside-promo-bar?milolibs=mwpw-165782--milo--deva309&newNav=true https://main--cc--adobecom.hlx.page/products/photoshop-lightroom?milolibs=mwpw-165782--milo--deva309&newNav=true DC: https://main--dc--adobecom.hlx.page/acrobat?milolibs=mwpw-165782--milo--deva309&newNav=true |
Skipped merging 3501: [MWPW-165782] - Hamburger icon issue fix due to failing checks |
Skipped 3501: "[MWPW-165782] - Hamburger icon issue fix" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
Resolves: MWPW-165782
Test URLs:
QA:
https://main--cc--adobecom.hlx.page/products/photoshop?newNav=false (before fix)
https://main--cc--adobecom.hlx.page/products/photoshop?newNav=false&milolibs=mwpw-165782--milo--deva309 (After fix)
https://main--cc--adobecom.hlx.page/products/photoshop-lightroom?milolibs=mwpw-165782--milo--deva309 (app banner issue fix)
https://main--federal--adobecom.hlx.page/federal/dev/blaishram/page-with-promo?milolibs=mwpw-165782--milo--deva309 (stickyheader with newNav disabled)