Skip to content

Fix(mwpw-161843): favicon is loaded fast. #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 5, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code optimization
  • Loading branch information
sharath-kannan committed Jan 2, 2025
commit 20650a53f60635a1709940e92092233032a94811
6 changes: 2 additions & 4 deletions libs/utils/utils.js
Original file line number Diff line number Diff line change
@@ -788,6 +788,8 @@ async function decorateHeader() {
if (breadcrumbs) header.append(breadcrumbs);
const promo = getMetadata('gnav-promo-source');
if (promo?.length) header.classList.add('has-promo');
const { default: loadFavIcon } = await import('./favicon.js');
loadFavIcon(createTag, getConfig(), getMetadata);
}

async function decorateIcons(area, config) {
@@ -1274,10 +1276,6 @@ function decorateMeta() {
function decorateDocumentExtras() {
decorateMeta();
decorateHeader();
(async () => {
const { default: loadFavIcon } = await import('./favicon.js');
loadFavIcon(createTag, getConfig(), getMetadata);
})();
}

async function documentPostSectionLoading(config) {