[MWPW-158773] : Aside notification CLS performance improvements #3536
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3536 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 260 260
Lines 60582 60584 +2
=======================================
+ Hits 58444 58446 +2
Misses 2138 2138 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aside notification component considers the width:auto for the lazy load image. This causes the text to shift right by the width of the loaded image and hence degrades CLS.
Resolves: MWPW-158773
Test URLs:
Before: https://main--bacom--adobecom.hlx.page/fragments/homepage/summit/summit-2025-product-page-promoid-5wyl7trb?martech=off
After: https://main--bacom--adobecom.hlx.page/fragments/homepage/summit/summit-2025-product-page-promoid-5wyl7trb?milolibs=mwpw-158773--milo--sharmeeatadobe&martech=off
Before: https://main--milo--adobecom.hlx.page/drafts/sharmeeb/aside-notification?martech=off
After: https://mwpw-158773--milo--sharmeeatadobe.hlx.page/drafts/sharmeeb/aside-notification?martech=off