Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change RANGEMAX default to 35 km #117

Closed
adokter opened this issue Mar 19, 2019 · 3 comments
Closed

change RANGEMAX default to 35 km #117

adokter opened this issue Mar 19, 2019 · 3 comments
Labels
bug
Milestone
0.6

Comments

@adokter
Copy link
Owner

adokter commented Mar 19, 2019

for consistency with bioRad paper
@adokter adokter mentioned this issue Mar 19, 2019
Closed
@adokter adokter added this to the 0.4 milestone Mar 19, 2019
adokter added a commit that referenced this issue Apr 23, 2019
@adokter
fix issue #117
0dbcc07
@adokter
Copy link
Owner Author

adokter commented Apr 23, 2019

closed by commit 0dbcc07

@adokter adokter closed this as completed Apr 23, 2019
@adokter adokter mentioned this issue Apr 23, 2019
Merged
@adokter adokter reopened this Jul 28, 2020
@adokter adokter added the bug label Jul 28, 2020
@adokter
Copy link
Owner Author

adokter commented Jul 28, 2020

The default behavior is still 25 km max range, because RANGEMAX has not been updated to 35000 in constants.h

adokter added a commit that referenced this issue Jul 28, 2020
@adokter
fix issue #117
e6f8908
@adokter adokter modified the milestones: 0.4, 0.6 Jul 28, 2020
@adokter
Copy link
Owner Author

adokter commented Jul 28, 2020

fixed by e6f8908.

@adokter adokter closed this as completed Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@adokter