Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with bioRad in application of sd_vvp #96

Closed
adokter opened this issue Jun 16, 2017 · 2 comments
Closed

Inconsistency with bioRad in application of sd_vvp #96

adokter opened this issue Jun 16, 2017 · 2 comments
Milestone

Comments

@adokter
Copy link
Owner

adokter commented Jun 16, 2017

Vol2bird sets bird densities to zero when there is a gap detected in the radial velocity field:

vol2bird/lib/libvol2bird.c

Lines 3888 to 3890 in 0eece2c

// set bird density values to zero if hasGap:
if (hasGap && birdDensity>0){
alldata->profiles.profile[iLayer*alldata->profiles.nColsProfile + 12] = 0.0;

BioRad does not consider this gap, and simply divides eta by the cross section

Need to make these two consistent

@adokter adokter added this to the bioRad paper milestone Jul 19, 2018
@adokter
Copy link
Owner Author

adokter commented Apr 11, 2019

Postprocessing efforts at UvA suggest that often you want to keep density when there is a gap, so therefore better to change vol2bird and keep bioRad as is

adokter added a commit that referenced this issue Nov 8, 2019
@adokter
Copy link
Owner Author

adokter commented Nov 8, 2019

No longer setting birdDensity to zero when hasGap is True. Closed by commit 83106a8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant