⚡ Bolt: Optimize CLI output string allocations #496
Conversation
- Cache colored TaskStatus strings using `once_cell::Lazy` to return `&'static str` instead of allocating `String` on every task. - Optimize `format_duration` to use `String::with_capacity` and `std::fmt::Write` to avoid intermediate string allocations in the hot path. - Avoid unnecessary string conversions in `task_result`. This reduces memory allocations for every task execution, improving performance for large playbooks. Co-authored-by: dolagoartur <146357947+dolagoartur@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Optimized
TaskStatus::colored_stringto return cached&'static strusingonce_cell::sync::Lazyand refactoredformat_durationto avoid intermediateStringallocations.🎯 Why:
TaskStatus::colored_stringwas allocating a newString(with ANSI codes) for every single task execution. In a playbook with many tasks/hosts, this adds up.format_durationwas using multipleformat!calls and slice manipulations that allocated temporary strings.📊 Impact:
TaskStatus::colored_stringis now zero-allocation after first use.🔬 Measurement:
cargo test --bin rustible output::tests.once_cellis an existing dependency.TaskStatussignature change is safe as it is internal to the binary crate's CLI module.PR created automatically by Jules for task 3146391609273665638 started by @dolagoartur