🛡️ Sentinel: [CRITICAL/HIGH] Fix insecure hash filter implementation #497
Conversation
Replaced the insecure `DefaultHasher` implementation in the `hash` filter with
proper cryptographic hash functions. Supported algorithms are `sha256` (default),
`sha512`, `md5`, `sha1`, and `blake3`.
- Used `sha2`, `md5`, `sha1`, `blake3` crates for consistent and standard hashing.
- Updated `hash` filter signature to return `Result` for better error handling.
- Added comprehensive tests for each supported algorithm.
- Removed misleading comments about `DefaultHasher`.
This ensures that `{{ 'value' | hash('sha256') }}` returns the actual SHA256 hash
instead of a random internal hash.
Co-authored-by: dolagoartur <146357947+dolagoartur@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fbc475dec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _ => Err(minijinja::Error::new( | ||
| minijinja::ErrorKind::InvalidOperation, | ||
| format!("Unsupported hash algorithm: {}", algo), |
There was a problem hiding this comment.
The parser’s hash filter now returns an error for any algorithm outside the hardcoded list. This is a behavioral regression for templates that use algorithms the project documents elsewhere (e.g., sha384, blake2b, blake2s in src/plugins/filter/hash.rs), or that previously relied on defaulting behavior. In those cases render_template will now fail and abort variable rendering, even though the rest of the system claims Ansible-compatible support. Consider aligning the parser’s supported algorithms with the documented list or defaulting to sha256 for unknown algorithms instead of raising an error.
Useful? React with 👍 / 👎.
1 participant
replaced
DefaultHasherinhashfilter with real cryptographic implementations (sha2,md5,sha1,blake3).PR created automatically by Jules for task 16918420736395756210 started by @dolagoartur