⚡ Bolt: Optimize deep_merge with in-place mutation #498
Conversation
Implements `deep_merge_in_place` to avoid recursive cloning of the entire base structure during variable merging. This significantly reduces memory allocations and copying overhead when merging large variable maps, especially with `HashBehaviour::Merge`. - Adds `deep_merge_in_place` to `src/vars/mod.rs` - Updates `deep_merge` to use the in-place implementation (backward compatible) - Updates `VarStore::merge_value` to use `deep_merge_in_place` directly - Adds unit tests for `deep_merge_in_place` Co-authored-by: dolagoartur <146357947+dolagoartur@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Optimized
deep_mergeto use in-place mutation instead of full structure cloning.🎯 Why:
deep_mergepreviously cloned the entire baseserde_yaml::Valuemap at every level of recursion, even for keys that weren't being modified. This caused unnecessary memory allocation and copying, O(N) for every merge operation.📊 Impact: significantly reduces memory allocations and copying overhead for variable merging, especially when
hash_behaviour = mergeis used or when merging deep structures.🔬 Measurement: Validated with unit tests ensuring behavior remains identical to the original implementation.
PR created automatically by Jules for task 14665495014126406948 started by @dolagoartur