π‘οΈ Sentinel: [MEDIUM] Fix Authorization header leakage on redirect #499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¨ Severity: MEDIUM
π‘ Vulnerability: The
UriModulemanually added theAuthorizationheader to requests.reqwestforwards manually set headers to redirected URLs, potentially leaking credentials to third-party domains if a redirect occurs.π― Impact: An attacker could potentially harvest credentials by redirecting a legitimate request to an attacker-controlled server.
π§ Fix: Updated
UriModuleto usereqwest::RequestBuilder::basic_auth()andbearer_auth(), which implement secure header handling on redirects.β Verification: Ran existing tests to ensure no regression. Manual verification of logic confirms alignment with
reqwestsecurity documentation.PR created automatically by Jules for task 11907547861682381057 started by @dolagoartur