🛡️ Sentinel: [CRITICAL] Fix git argument injection via repo/remote params #501
Conversation
The `git` module accepted arbitrary strings for `repo` and `remote` parameters, which could be exploited to inject flags (e.g., `--upload-pack`) into the underlying `git` command. This change adds validation to reject `repo` and `remote` strings that start with a hyphen (`-`). Includes: - Validation logic in `validate_params` - Regression test case verifying the rejection of malicious inputs - Journal entry in `.jules/sentinel.md` Co-authored-by: dolagoartur <146357947+dolagoartur@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
adolago
deleted the
sentinel/git-argument-injection-fix-5602171768547906443
branch
1 participant
Identified and fixed a Git argument injection vulnerability where
repoandremoteparameters were not validated, allowing them to start with-and be interpreted as flags. Added strict validation to reject such inputs and included regression tests.PR created automatically by Jules for task 5602171768547906443 started by @dolagoartur